Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate subprojects.build.grade to kotlin #5203

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

soloturn
Copy link
Contributor

@soloturn soloturn commented Jan 2, 2024

split out from #5204, prepare kotlin migrate with double quotes, and make the files slighty more similar in the logic. and this pull reuqest really doing the kotlin migrate. changes should be more clearly visible in the github diff view and make review easier.

@github-actions github-actions bot added the Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. label Jan 2, 2024
@soloturn soloturn changed the base branch from develop to qa/subproj-kotlin January 2, 2024 07:49
@soloturn soloturn force-pushed the qa/kotlin-subproj branch 3 times, most recently from 8a011bb to 9498242 Compare January 3, 2024 23:17
@BenjaminAmos BenjaminAmos changed the base branch from qa/subproj-kotlin to develop January 6, 2024 19:14
@BenjaminAmos
Copy link
Contributor

#5204 has been merged. Could you rebase this one on-top of develop and resolve any conflicts?

@soloturn
Copy link
Contributor Author

soloturn commented Jan 6, 2024

rebased.

@BenjaminAmos BenjaminAmos merged commit 8f37f92 into develop Jan 8, 2024
9 checks passed
@BenjaminAmos BenjaminAmos deleted the qa/kotlin-subproj branch January 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants