Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): set jacoco excludes for engine-test's unitTest and integrationTest tasks #5013

Merged
merged 2 commits into from
May 16, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented May 12, 2022

upgrade to jacoco 0.8.8 (from 0.8.5)

relates to #4985

How to test

Run integrationTest and unitTest

Run jacocoTestReport

check to see if test output contains loads of messages about IllegalClassFormat

It Would Be Nice If

It would be good to have less configuration duplication. The excludes-list is set in several places,
and there are probably places that need it but don't have it yet. (module tests? subsystem tests?)

@keturn keturn added Type: Bug Issues reporting and PRs fixing problems Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research labels May 12, 2022
…tionTest tasks

upgrade to jacoco 0.8.8 (from 0.8.5)

relates to #4985
@keturn
Copy link
Member Author

keturn commented May 13, 2022

jacoco config

skaldarnar
skaldarnar previously approved these changes May 15, 2022
engine-tests/build.gradle Show resolved Hide resolved
config/gradle/common.gradle Show resolved Hide resolved
Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants