Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PathManager): working directory should always be a fallback #4895

Merged
merged 1 commit into from
Sep 7, 2021
Merged

fix(PathManager): working directory should always be a fallback #4895

merged 1 commit into from
Sep 7, 2021

Conversation

keturn
Copy link
Member

@keturn keturn commented Sep 7, 2021 •
edited
Loading

A recent PathManager change (#4890) broke some tests under Jenkins module builds.

Here are the Health tests run on Nanoware with this PR applied, and its MTE tests are passing again: https://jenkins.terasology.io/teraorg/job/Nanoware/job/TerasologyModules/job/H/job/Health/job/develop/21/testReport/

@keturn
fix(PathManager): working directory should always be a fallback
1c21d55 
Not only in the case of URISyntaxException.
@keturn keturn added Type: Bug Issues reporting and PRs fixing problems Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research labels Sep 7, 2021
@keturn keturn added this to the v5.2.0 milestone Sep 7, 2021
@keturn keturn assigned keturn and unassigned keturn Sep 7, 2021
@skaldarnar skaldarnar merged commit a4b70d8 into develop Sep 7, 2021
@skaldarnar skaldarnar deleted the fix/pathManagerForCI branch September 7, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees
No one assigned
Labels
Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keturn @skaldarnar