chore(PathManager): remove some "probably isn't needed anymore" code #4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this breaks anything, let's document that use case better next time.
keturn
added
Topic: Stabilization
github-actions
bot
added
the
Type: Chore
pollend
approved these changes
Sep 5, 2021
skaldarnar
pushed a commit
that referenced
this pull request
Sep 7, 2021
A recent PathManager change (#4890) broke some tests under Jenkins module builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this breaks anything, let's document that use case better next time.
This PR does help when trying to run certain gradle tasks for modules, related to https://youtrack.jetbrains.com/issue/IDEA-277315
How to test
The thing this has the potential to break is finding the path to the native libraries. Try starting the game (or other tests linked to code in the native libraries) and make sure it doesn't crash with a library-not-found error.