-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EmbeddedAnsible ScmCredential parent class #22577
Fix EmbeddedAnsible ScmCredential parent class #22577
Conversation
8b8c1b6
to
9eaeb64
Compare
All EmbeddedAnisble credentials should derive from the `EmbeddedAnsible::AutomationManager::Credential` class.
9eaeb64
to
1595ebd
Compare
Checked commit agrare@1595ebd with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
I don't love the mixin, but i see why it's needed as it's the only way to "share" the ScmCredential code with workflows while maintaining 2 independent hierarchies. |
Yeah I agree which is why I avoided it initially, but if we want to share "SCM" type params while keeping two different class hierarchies I don't see another option. |
@agrare A conflict occurred during the backport of this pull request to If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the Conflict details: * Unmerged path app/models/manageiq/providers/embedded_automation_manager/scm_credential.rb |
Backported to
|
…tial_parent_class Fix EmbeddedAnsible ScmCredential parent class (cherry picked from commit 60bc7dc)
All EmbeddedAnisble credentials should derive from the
EmbeddedAnsible::AutomationManager::Credential
class.This was causing issues with displaying all Embedded Ansible credentials by doing
ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Credential.all
specifically in the UI.Dependents: