Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent class for Workflows ScmCredential #32

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix parent class for Workflows ScmCredential #32

merged 1 commit into from
Jun 23, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 23, 2023 •
edited by Fryguy
Loading

@agrare agrare added bug Something isn't working petrosian/yes? labels Jun 23, 2023
@agrare agrare mentioned this pull request Jun 23, 2023
Merged
@miq-bot
Copy link
Member

miq-bot commented Jun 23, 2023

Checked commit agrare@a1fb21d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit e6d6902 into ManageIQ:master Jun 23, 2023
3 checks passed
@Fryguy Fryguy self-assigned this Jun 23, 2023
@agrare agrare deleted the fix_scm_credential_class_parent branch June 23, 2023 19:15
@Fryguy
Copy link
Member

Fryguy commented Jun 28, 2023

Backported to petrosian in commit e356185.

commit e356185e03112a06fb8a637ac2f34cd17e6022b1
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jun 23 15:12:55 2023 -0400

    Merge pull request #32 from agrare/fix_scm_credential_class_parent
    
    Fix parent class for Workflows ScmCredential
    
    (cherry picked from commit e6d690228a464673b230830c536daebc94f5534a)

Fryguy added a commit that referenced this pull request Jun 28, 2023
@Fryguy
Merge pull request #32 from agrare/fix_scm_credential_class_parent
e356185 
Fix parent class for Workflows ScmCredential

(cherry picked from commit e6d6902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fryguy Fryguy

Labels
bug Something isn't working petrosian/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy