-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a default params_to_attributes for EmbeddedAutomationManager Authentications #22570
Add a default params_to_attributes for EmbeddedAutomationManager Authentications #22570
Conversation
ea67932
to
ae7c19c
Compare
@miq-bot cross-repo-tests manageiq-providers-awx, manageiq-providers-ansible_tower, manageiq-api, manageiq-ui-classic |
From Pull Request: ManageIQ/manageiq#22570
ae7c19c
to
4696948
Compare
@miq-bot cross-repo-tests manageiq-providers-awx, manageiq-providers-ansible_tower, manageiq-api, manageiq-ui-classic, manageiq-providers-workflows |
From Pull Request: ManageIQ/manageiq#22570
270921d
to
20eedfc
Compare
Checked commits agrare/manageiq@4696948~...20eedfc with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Okay this is ready for review |
From Pull Request: ManageIQ/manageiq#22570
From Pull Request: ManageIQ/manageiq#22570
Cross-repo is green ManageIQ/manageiq-cross_repo-tests#805 |
def self.params_to_attributes(_params) | ||
raise NotImplementedError, "must be implemented in a subclass" | ||
def self.params_to_attributes(params) | ||
allowed_params = self::API_ATTRIBUTES.pluck(:id) + %w[name type options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to put name, type, options
into COMMON_ATTRIBUTES
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because API_ATTRIBUTES
is used by ui-classic to build dynamic dialogs (https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/ansible_credential_helper/textual_summary.rb#L15) so if we add them there they will show up on the UI which we don't want.
Backported to
|
Add a default params_to_attributes for EmbeddedAutomationManager Authentications (cherry picked from commit a928eaa)
Use API_ATTRIBUTES to filter allowed parameters for embedded automation manager authentications
followup: