Updated Workflows Credential Schema #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit DavidResende0@f0422ad with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
reviewed
Jun 22, 2023
Comment on lines
-8
to
-14
| { | ||
| :component => 'text-field', | ||
| :label => N_('Name'), | ||
| :helperText => N_('Name of this credential'), | ||
| :name => 'name', | ||
| :id => 'name' | ||
| }, |
There was a problem hiding this comment.
If we're going to remove name from COMMON_ATTRIBUTES then we need to add it to the list of allowed_params in .params_to_attributes here (this is why the specs are failing)
There was a problem hiding this comment.
Adding name to the core set of allowed attributes in ManageIQ/manageiq#22570 fixes this.
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jun 28, 2023
Updated Workflows Credential Schema (cherry picked from commit e49a229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
Namefield from theManageIQ::Providers::Workflows::AutomationManager::Credentialtype schema since name is a common field across credential types and should be in the front-end. Also added some validation to theReferencefield since it is a required field.