-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reference images (against PR #73) #83
Conversation
Expose edge_paths to users
Compatibility with Makie 0.17
Replace `MakieLayout` with `Makie`
Codecov Report
@@ Coverage Diff @@
## edgelabelorient #83 +/- ##
==================================================
Coverage ? 79.40%
==================================================
Files ? 4
Lines ? 539
Branches ? 0
==================================================
Hits ? 428
Misses ? 111
Partials ? 0 Continue to review full report at Codecov.
|
Seems fine to me. it doesn't really matter how the plots in |
Great! I've merged the latest |
@@ -1,5 +1,6 @@ | |||
[deps] | |||
CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0" | |||
Cbc = "9961bab8-2fa3-5c5a-9d89-47fab24efd76" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why cbc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how that happened. Will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line was added by you :-) b8ba9ad
It shows up here because I merged master into this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#78
ah yes, i remeber now, this was a hotfix to adress Makie@0.17 compat...
sorry :D
This contains
twothree new commits (I also merged current master into this branch)plots.jl-14.png
TO DO: adjust the offset
reftests.jl-04.png
TO DO: leave as is?
reftests.jl-05.png
TO DO: adjust axis limits so the label is not cut off?