-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Makie 0.17 #78
Conversation
this breaks every test with arrows in plots. weird... what happend there? |
Huh...just ran this locally, I have no idea what is going on - it seems like the marker size might have blown up or something. |
Weird indeed.. I thought it's maybe an old Makie version, but the tests seem to use 0.16.6. |
I am wondering how |
Huh, maybe actually the changes that introduced |
Makie@0.17 seems to change the glyph placement, I've updated the reference images. Documentation won't run because it can't find some lib used in Jump... not sure what to do there |
Pixel
-> :pixel
in markerspace
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 78.88% 78.88%
=======================================
Files 4 4
Lines 521 521
=======================================
Hits 411 411
Misses 110 110
Continue to review full report at Codecov.
|
Looks like some JLLs didn't compile - Cbc_jll and Cgl_jll. This caused upstream libraries to fail. |
Fixes a small error which caused some graphs to be unusable. I ran into this when trying to use OSMMakie.