Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video reader #55

Merged

Conversation

Shmuel-columbia
Copy link
Contributor

No description provided.

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
demo_app.py Outdated Show resolved Hide resolved
demo_app.py Outdated Show resolved Hide resolved
demo_app.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@themattinthehatt themattinthehatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments about the doubled text, as well as a couple other comments. Please be sure to run flake8 . from inside the Pose-app directory and fix all issues related to the files you updated (as before, don't worry about other files that you didn't touch).

Also, now is a good opportunity to start running the tests before you make final commits. After making your updates, and running flake8, then run (from inside Pose-app directory)

pytest tests

You'll see the tests run, should take a minute or so, without error. If there are errors let me know and we can try to fix them.

Once the code is updated, flaked, and tested, then make the commit and I'll look at the PR again.

lightning_pose_app/ui/streamlit_video_viewer.py Outdated Show resolved Hide resolved
lightning_pose_app/ui/streamlit_video_viewer.py Outdated Show resolved Hide resolved
lightning_pose_app/ui/extract_frames.py Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove all green highlighted lines from this file

@themattinthehatt themattinthehatt merged commit d499b37 into Lightning-Universe:develop Feb 27, 2024
3 of 4 checks passed
@Shmuel-columbia Shmuel-columbia deleted the video_viewer branch April 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants