-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project_ui_update #51
Project_ui_update #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first pass! Try to fix everything before we meet tomorrow, but don't worry about a new commit yet. I'll show you how to do code linting as well, which finds violations of code formatting conventions. After that you can do a final push.
@@ -310,7 +308,8 @@ def _train(self, inputs, outputs, cfg_overrides, results_dir): | |||
# get save name labeled video csv | |||
if cfg.eval.save_vids_after_training: | |||
labeled_vid_dir = os.path.join(video_pred_dir, "labeled_videos") | |||
labeled_mp4_file = os.path.join(labeled_vid_dir, video_pred_name + "_labeled.mp4") | |||
labeled_mp4_file = os.path.join(labeled_vid_dir, | |||
video_pred_name + "_labeled.mp4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this go back to one line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. >99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
e47bdb2
into
Lightning-Universe:develop
Create project - Add popup and links