update package info #768
Merged
update package info #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
commented
Jan 30, 2020
pytorch_lightning/core/lightning.py
Outdated
| @@ -106,6 +105,7 @@ def forward(self, batch): | |||
| return logits | |||
|
|
|||
| """ | |||
| warnings.warn('Model does not have implemented `forward` method.') | |||
There was a problem hiding this comment.
I would rather keep this abstract so a user has to willingly replace/fill by pass... @williamFalcon @neggert
There was a problem hiding this comment.
@Borda that breaks convention with pytorch. let's not keep this abstract.
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update some package information like year or version is devel now...
Partially fixing #731 and duplicate to #761
Adding budge for Appveyor #626
Also fixed:
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.