Update __init__.py #761
Closed
Update __init__.py #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevent the python `logging` module to override the `pytorch_lightning.logging` module. This fix issue Lightning-AI#731
Borda
requested changes
Jan 28, 2020
pytorch_lightning/__init__.py
Outdated
| @@ -28,11 +28,12 @@ | |||
| from .trainer.trainer import Trainer | |||
| from .core.lightning import LightningModule | |||
| from .core.decorators import data_loader | |||
| import logging | |||
|
|
|||
| def set_logger_level(): | |||
There was a problem hiding this comment.
I would rather use from logging import basicConfig
Merged
|
@Borda is this still alive? should we close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevent the python
loggingmodule to override thepytorch_lightning.loggingmodule. This fix issue #731Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃