Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tensorboard version #3132

Merged
merged 11 commits into from
Sep 15, 2020
Merged

fix tensorboard version #3132

merged 11 commits into from
Sep 15, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 24, 2020

What does this PR do?

Fixes #3011
Fixes #3033

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Aug 24, 2020
@Borda Borda added this to the 0.9.x milestone Aug 24, 2020
@Borda
Copy link
Member Author

Borda commented Aug 24, 2020

just thinking, all tests are passing... what was the failing case?

@Borda Borda marked this pull request as ready for review August 24, 2020 23:13
@mergify mergify bot requested a review from a team August 24, 2020 23:14
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #3132 into master will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3132    +/-   ##
=======================================
- Coverage      90%     85%    -5%     
=======================================
  Files         104      98     -6     
  Lines        8126    8073    -53     
=======================================
- Hits         7314    6898   -416     
- Misses        812    1175   +363     

@Borda Borda mentioned this pull request Aug 25, 2020
@pep8speaks
Copy link

pep8speaks commented Aug 25, 2020

Hello @Borda! Thanks for updating this PR.

Line 38:1: W293 blank line contains whitespace
Line 52:1: W293 blank line contains whitespace

Comment last updated at 2020-09-15 18:40:02 UTC

@Borda Borda force-pushed the tensorboard-version branch 2 times, most recently from 6061dfa to 222d247 Compare August 31, 2020 10:27
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2020

This pull request is now in conflict... :(

@Borda
Copy link
Member Author

Borda commented Sep 3, 2020

this seems quite unrelated...

        # verify tb logs
>       event_acc = EventAccumulator(folder_path)
E       NameError: name 'EventAccumulator' is not defined

@Borda Borda mentioned this pull request Sep 3, 2020
@Borda Borda changed the title tensorboard version drop tensorboard dependency Sep 3, 2020
@Borda Borda added the feature Is an improvement or enhancement label Sep 3, 2020
@Borda Borda mentioned this pull request Sep 3, 2020
7 tasks
@mergify mergify bot requested a review from a team September 3, 2020 19:23
@mergify mergify bot requested a review from a team September 3, 2020 19:27
@Borda
Copy link
Member Author

Borda commented Sep 8, 2020

this is a funny dependency, PT made it as optional as we do... so we cannot drop it :(
File "/Users/runner/hostedtoolcache/Python/3.6.12/x64/lib/python3.6/site-packages/torch/utils/tensorboard/__init__.py", line 1, in <module>

@Borda Borda changed the title drop tensorboard dependency fix tensorboard version Sep 8, 2020
@mergify mergify bot requested a review from a team September 9, 2020 07:24
@Borda Borda added the ready PRs ready to be merged label Sep 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2020

This pull request is now in conflict... :(

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team September 10, 2020 07:40
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

This pull request is now in conflict... :(

@Borda
Copy link
Member Author

Borda commented Sep 15, 2020

seems only Horovod id failing, unrelated to this PR

FAILED tests/models/test_horovod.py::test_horovod_cpu - assert 1 == 0
FAILED tests/models/test_horovod.py::test_horovod_cpu_implicit - assert 1 == 0

@Borda Borda merged commit c64520e into master Sep 15, 2020
@Borda Borda deleted the tensorboard-version branch September 15, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.9.0 rc16 tensorboard 2.3.0 can't find hparams data
6 participants