Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tensorboard 2.3.0 #3011

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

bryant1410
Copy link
Contributor

What does this PR do?

Unpin tensorboard version. 2.3.0 works fine for me, and otherwise it gets downgraded when I install PL.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 17, 2020 01:13
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #3011 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3011   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          81      81           
  Lines        7644    7644           
======================================
  Hits         6878    6878           
  Misses        766     766           

@williamFalcon williamFalcon merged commit 6921d5e into Lightning-AI:master Aug 17, 2020
ameliatqy pushed a commit to ameliatqy/pytorch-lightning that referenced this pull request Aug 17, 2020
@romesco
Copy link
Contributor

romesco commented Aug 17, 2020

@bryant1410 just a heads up, at least for me, 2.3.0 breaks hparam logging, but 2.2.0 works fine.

@Borda Borda added the bug Something isn't working label Aug 17, 2020
@Borda
Copy link
Member

Borda commented Aug 17, 2020

it seems that our testing was passing, so @romesco mind adding a test (send a PR) to show the failing so we can fix it... 🐰

@romesco
Copy link
Contributor

romesco commented Aug 18, 2020

@Borda sure thing, PR #3040

@romesco romesco mentioned this pull request Aug 18, 2020
7 tasks
@Borda Borda added this to the 0.9.0 milestone Aug 20, 2020
@Borda Borda mentioned this pull request Aug 24, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants