-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests drop macOS py38 #2054
tests drop macOS py38 #2054
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
======================================
Coverage 86% 86%
======================================
Files 75 75
Lines 4705 4705
======================================
Hits 4064 4064
Misses 641 641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will hopefully have time in next week to look more into what is causing this particular test to fail on Mac, so we can get the mac+python3.8 up and running again
Do we know which commit introduced it? |
|
@williamFalcon if we want to have skipped just a particular test I or someone else has to be running it locally, debuting it on CI would take days as it is incremental work and each iteration takes about 20min so I propose to drop the macOS with py3.8 completely, for now, to unblock waiting all PRs and in meantime @SkafteNicki will find the issue.. |
fe44ad4
to
286ebf4
Compare
286ebf4
to
28f7bae
Compare
* tests drop macOS py38 * ignore single test * try freeze env * drop * drop * drop * drop * drop skips * drop macOS py38 * imports
What does this PR do?
Fixes #2039 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃