Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests drop macOS py38 #2054

Merged
merged 10 commits into from
Jun 3, 2020
Merged

tests drop macOS py38 #2054

merged 10 commits into from
Jun 3, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 2, 2020

What does this PR do?

Fixes #2039 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task ci Continuous Integration labels Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2054 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2054   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          75      75           
  Lines        4705    4705           
======================================
  Hits         4064    4064           
  Misses        641     641           

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will hopefully have time in next week to look more into what is causing this particular test to fail on Mac, so we can get the mac+python3.8 up and running again

@awaelchli
Copy link
Member

Do we know which commit introduced it?
I suspect it is the #2029 but not sure. I would start backtracking it by resetting the head to before that PR and see when the tests start to hang.

@Borda
Copy link
Member Author

Borda commented Jun 2, 2020

Do we know which commit introduced it?
I suspect it is the #2029 but not sure. I would start backtracking it by resetting the head to before that PR and see when the tests start to hang.

Yes, it is... 8-)
Screenshot at 2020-06-02 21-40-39

@Borda Borda added the ready PRs ready to be merged label Jun 2, 2020
@mergify mergify bot requested a review from a team June 2, 2020 20:04
@Borda Borda removed the ready PRs ready to be merged label Jun 2, 2020
@Borda Borda marked this pull request as draft June 3, 2020 07:58
@Borda
Copy link
Member Author

Borda commented Jun 3, 2020

@williamFalcon if we want to have skipped just a particular test I or someone else has to be running it locally, debuting it on CI would take days as it is incremental work and each iteration takes about 20min so I propose to drop the macOS with py3.8 completely, for now, to unblock waiting all PRs and in meantime @SkafteNicki will find the issue..

@Borda Borda marked this pull request as ready for review June 3, 2020 09:25
@Lightning-AI Lightning-AI deleted a comment from mergify bot Jun 3, 2020
@Lightning-AI Lightning-AI deleted a comment from mergify bot Jun 3, 2020
@williamFalcon williamFalcon merged commit b4eb6ef into master Jun 3, 2020
@Borda Borda deleted the tests/drop-xOS-py38 branch June 3, 2020 11:42
@Borda Borda mentioned this pull request Jun 3, 2020
justusschock pushed a commit that referenced this pull request Jun 29, 2020
* tests drop macOS py38

* ignore single test

* try freeze env

* drop

* drop

* drop

* drop

* drop skips

* drop macOS py38

* imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants