Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/drop macos py38 #2061

Merged
merged 10 commits into from
Jun 3, 2020
Merged

Tests/drop macos py38 #2061

merged 10 commits into from
Jun 3, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 3, 2020

What does this PR do?

Fixes #2054

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Jun 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2020

This pull request is now in conflict... :(

@mergify mergify bot requested a review from a team June 3, 2020 11:49
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2061 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2061   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files          75      75           
  Lines        4705    4705           
======================================
  Hits         4064    4064           
  Misses        641     641           

@williamFalcon williamFalcon merged commit 5d93d57 into master Jun 3, 2020
@Borda Borda deleted the tests/drop-macos-py38 branch June 3, 2020 12:50
justusschock pushed a commit that referenced this pull request Jun 29, 2020
* tests drop macOS py38

* ignore single test

* try freeze env

* drop

* drop

* drop

* drop

* drop skips

* imports

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants