Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost data-testid on plaintext config card items #866

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Oct 24, 2023

Summary

Update the tag prop on the componentAttrsData to match the tag which is now a KTooltip

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@filipgutica filipgutica requested review from a team as code owners October 24, 2023 22:01
@filipgutica filipgutica force-pushed the fix/lost-data-test-id-plaintext-config-card-item branch from e7bfa8a to 8cab632 Compare October 24, 2023 22:05
@filipgutica filipgutica enabled auto-merge (squash) October 24, 2023 22:12
@filipgutica filipgutica merged commit 95550c3 into main Oct 24, 2023
18 checks passed
@filipgutica filipgutica deleted the fix/lost-data-test-id-plaintext-config-card-item branch October 24, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants