fix: lost data-testid on plaintext config card items (#866)

* fix: lost data-testid on plaintext config card items * fix: add test
Kong · Oct 24, 2023 · 95550c3 · 95550c3
1 parent 7cacb63
commit 95550c3
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/...ages/entities/entities-shared/src/components/entity-base-config-card/ConfigCardItem.cy.ts b/...ages/entities/entities-shared/src/components/entity-base-config-card/ConfigCardItem.cy.ts
@@ -549,6 +549,24 @@ describe('<ConfigCardItem />', () => {
         cy.getTestId(`${item.key}-external-link`).should('contain.text', link)
         cy.get(`a[href="${link}"]`).should('exist')
       })
+
+      it('plaintext config card item has data-testid', () => {
+        const item: RecordItem = {
+          type: ConfigurationSchemaType.Text,
+          key: 'textItem',
+          label: 'textItem',
+          value: 'asdf',
+        }
+
+        cy.mount(ConfigCardItem, {
+          props: {
+            item,
+          },
+        })
+
+        cy.get('[data-testid="textItem-plain-text"]').should('exist')
+        cy.get('[data-testid="textItem-plain-text"]').should('contain.text', 'asdf')
+      })
     })
   })
 })
diff --git a/packages/entities/entities-shared/src/components/entity-base-config-card/ConfigCardItem.vue b/packages/entities/entities-shared/src/components/entity-base-config-card/ConfigCardItem.vue
@@ -288,7 +288,7 @@ const componentAttrsData = computed((): ComponentAttrsData => {
 
     default:
       return {
-        tag: 'div',
+        tag: 'KTooltip',
         attrs: {
           'data-testid': `${props.item.key}-plain-text`,
         },