-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to request reservations #174
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d5789c
Added a way to request reservations
KiOui 2c050d6
Update website/venues/forms.py
KiOui e1de5f7
Added use of messages
KiOui 5aa4c0e
Merge branch 'feature/reservation-requests' of github.com:KiOui/TOSTI…
KiOui a7df348
Update website/venues/views.py
KiOui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
from django import forms | ||
from django.core.exceptions import ValidationError | ||
from django.db.models import Q | ||
from django.utils import timezone | ||
|
||
from .models import Reservation | ||
from .models import Venue | ||
|
||
|
||
class ReservationForm(forms.ModelForm): | ||
KiOui marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""Reservation Form.""" | ||
|
||
def __init__(self, *args, **kwargs): | ||
"""Initialise Reservation Form.""" | ||
request = kwargs.pop("request", None) | ||
super(ReservationForm, self).__init__(*args, **kwargs) | ||
self.fields["venue"].queryset = Venue.objects.filter(can_be_reserved=True) | ||
if request is not None and request.user.is_authenticated and request.user.profile.association is not None: | ||
self.fields["association"].initial = request.user.profile.association | ||
|
||
def clean(self): | ||
""" | ||
Clean data. | ||
|
||
Check whether there is no overlapping Reservation. | ||
""" | ||
if self.cleaned_data.get("start_time") is not None and self.cleaned_data.get("end_time") is not None: | ||
start_time = self.cleaned_data.get("start_time").astimezone(timezone.get_current_timezone()) | ||
end_time = self.cleaned_data.get("end_time").astimezone(timezone.get_current_timezone()) | ||
|
||
if ( | ||
Reservation.objects.filter(venue=self.cleaned_data.get("venue")) | ||
.filter(accepted=True) | ||
.filter( | ||
Q(start_time__lte=start_time, end_time__gt=start_time) | ||
| Q(start_time__lt=end_time, end_time__gte=end_time) | ||
| Q(start_time__gte=start_time, end_time__lte=end_time) | ||
) | ||
.exists() | ||
): | ||
raise ValidationError("An overlapping reservation for this venue already exists.") | ||
|
||
class Meta: | ||
"""Meta class.""" | ||
|
||
model = Reservation | ||
fields = ["venue", "association", "start_time", "end_time", "title", "comment"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 3.2.8 on 2021-10-15 09:25 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('venues', '0002_auto_20211012_2042'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='reservation', | ||
name='accepted', | ||
field=models.BooleanField(blank=True, default=None, null=True), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{% extends 'tosti/base.html' %} | ||
{% load static %} | ||
|
||
{% block styles %} | ||
{{ block.super }} | ||
<link href='{% static "tosti/css/forms.css" %}' rel='stylesheet' /> | ||
{% endblock %} | ||
|
||
{% block page %} | ||
<div class="container text-left"> | ||
<a href="{% url 'venues:calendar' %}"><i class="fas fa-arrow-left"></i> back to calendar</a> | ||
</div> | ||
<div class="container mt-5 mb-5 text-center"> | ||
<h1>Request a Reservation</h1> | ||
</div> | ||
<div class="container mt-5 mb-5 text-center"> | ||
{% if messages %} | ||
KiOui marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{% for message in messages %} | ||
<p class="alert {{ message.tags }}">{{ message }}</p> | ||
{% endfor %} | ||
{% endif %} | ||
</div> | ||
<div class="container-sm text-center mb-5"> | ||
<form method="post"> | ||
{% csrf_token %} | ||
{{ form.as_p }} | ||
<input type="submit" value="Submit" class="btn-ml btn-on"> | ||
</form> | ||
</div> | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
from django.urls import path | ||
|
||
from venues.views import VenueCalendarView | ||
from venues import views | ||
|
||
urlpatterns = [ | ||
path("calendar/", VenueCalendarView.as_view(), name="calendar"), | ||
path("calendar/", views.VenueCalendarView.as_view(), name="calendar"), | ||
KiOui marked this conversation as resolved.
Show resolved
Hide resolved
|
||
path("calendar/add-reservation/", views.RequestReservationView.as_view(), name="add_reservation"), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,43 @@ | ||
from django.views.generic import TemplateView | ||
from django.contrib import messages | ||
from django.contrib.auth.mixins import LoginRequiredMixin | ||
from django.shortcuts import redirect | ||
from django.urls import reverse | ||
from django.views.generic import TemplateView, FormView | ||
|
||
from venues.forms import ReservationForm | ||
|
||
|
||
class VenueCalendarView(TemplateView): | ||
"""All venues calendar view.""" | ||
|
||
template_name = "venues/calendar.html" | ||
|
||
|
||
class RequestReservationView(LoginRequiredMixin, FormView): | ||
"""Request Reservation view.""" | ||
|
||
template_name = "venues/reservation_request.html" | ||
form_class = ReservationForm | ||
|
||
def get_form_kwargs(self): | ||
"""Get the kwargs for rendering the form.""" | ||
kwargs = super(RequestReservationView, self).get_form_kwargs() | ||
kwargs.update( | ||
{ | ||
"request": self.request, | ||
} | ||
) | ||
return kwargs | ||
|
||
def form_valid(self, form): | ||
"""Save the form and add User data.""" | ||
instance = form.save(commit=False) | ||
instance.user = self.request.user | ||
instance.save() | ||
messages.success(self.request, "Reservation request added successfully.") | ||
return redirect(reverse("venues:add_reservation")) | ||
|
||
def get_context_data(self, **kwargs): | ||
"""Get the context data for rendering the template.""" | ||
context = super(RequestReservationView, self).get_context_data(**kwargs) | ||
return context |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the unaccepted reservations should be shown in a opaque color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will experiment with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You decided not to do it?