-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to request reservations #174
Conversation
You also want to create a LogEntry for such actions, like https://github.com/svthalia/concrexit/blob/b600592fb6a79383578a2b39186c159ec1822f6d/website/registrations/services.py#L175-L181 does |
@@ -43,7 +43,7 @@ class VenueReservationListAPIView(ListAPIView): | |||
""" | |||
|
|||
serializer_class = ReservationSerializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the unaccepted reservations should be shown in a opaque color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will experiment with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You decided not to do it?
Co-authored-by: Job Doesburg <job.doesburg@gmail.com>
… into feature/reservation-requests
Where for exactly? Adding a |
For changing the status. I think Django will only say "the reservation has changed" but will not display it as "the reservation is approved". Not sure though |
Apart from these 3 small comments, it looks good to me |
Co-authored-by: Job Doesburg <job.doesburg@gmail.com>
Added the following:
accepted
field toReservation
s which indicates whether theReservation
is active/acceptedA way to see
Reservation
requests will be added once we have created theborrel
application (see #172)