Add support for VK_PRIMITIVE_TOPOLOGY_TRIANGLE_FAN. #1962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce complexity and repetitive copy-pasted spaghetti code, the design approach here was to implement triangle fan conversion on
MVKCmdDrawIndexedIndirect
, as the most general of the draw commands, and then populate and invoke a syntheticMVKCmdDrawIndexedIndirect
command from the other draw commands.Rename pipeline factory shader
cmdDrawIndexedIndirectMultiviewConvertBuffers()
tocmdDrawIndexedIndirectConvertBuffers()
, and in addition to original support for modifying indirect content to support multiview, add support for converting triangle fan indirect content and indexes to triangle list.Modify
MVKCmdDrawIndexedIndirect
to track need to convert triangle fans to triangle list, and invoke kernel function when needed.Modify
MVKCmdDraw
,MVKCmdDrawIndexed
, andMVKCmdDrawIndirect
to populate and invoke a syntheticMVKCmdDrawIndexedIndirect
command to convert triangle fans to triangle lists.Add pipeline factory shader
cmdDrawIndirectPopulateIndexes()
to convert non-indexed indirect content to indexed indirect content.MVKCmdDrawIndexedIndirect
add support for zero divisor vertex buffers potentially coming fromMVKCmdDraw
andMVKCmdDrawIndexed
.Rename pipeline factory shader
cmdDrawIndexedIndirectConvertBuffers()
tocmdDrawIndexedIndirectTessConvertBuffers()
so it will be invoked fromMVKCommandEncodingPool::getCmdDrawIndirectTessConvertBuffersMTLComputePipelineState()
(unrelated).Fixes #1419.
Fixes #1799.