-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VkPrimitiveTopology value 5 is not supported #1799
Comments
I think somone found a fix here: #81 |
RPCS3 the PS3 emulator "implemented" this a while back https://github.com/RPCS3/rpcs3/search?q=triangle+fans&type=commits |
Since the app is free to submit vertices and indices at any time, and MoltenVK would have no knowledge of whether the vertices had been massaged from fan to strip yet, to do this in MoltenVK, it would be best to massage the vertices or indexes using a compute shader that copied from one buffer to another before each triangle fan draw call, and then substitute the strip buffer in just before the actual Metal draw call. At a minimum, this would involved breaking out of the Metal renderpass to run the compute shader. We do that for tessellation right now, so we have precedence for it, but it is something to consider from a structural and performance perspective. Are triangle fans a must-have because some games that can't be modified at the source are using them? |
Afaik this was deprecated on D3D10+ . So we're talking about a subset of old games mainly. Emulators again afaik have implemented workarounds. |
Yup. Looks like it. Thanks for pointing this out. |
No Man's Sky uses triangle fans in its UI: |
PR # #1962 implements triangle fans. |
I'm trying to launch a game but I get a bunch of lines in the log stating that VkPrimitiveTopology value 5 is not supported and Metal does not support triangle fans. Is there any possible way to implement this into moltenVK?
FullLog.txt
The text was updated successfully, but these errors were encountered: