Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard recipe: quest-v3.4.1 #3815

Conversation

Roger-luo
Copy link
Contributor

This pull request contains a new build recipe I built using the BinaryBuilder.jl wizard:

  • Package name: quest
  • Version: v3.4.1

@staticfloat please review and merge.


# These are the platforms we will build for by default, unless further
# platforms are passed in on the command line
platforms = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is limited to a subset of all supported platforms or can we go for the full platforms = supported_platforms(; experimental=true) and open up (among others) Apple silicon support?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roger-luo I presume your question about conditional instructions in Slack was related to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ARM doesn't have avx which is causing the build to fail. Also I'm not sure what kind of simd flag should arm processors have

@imciner2
Copy link
Member

imciner2 commented Apr 3, 2024

Closing due to inactivity. Please submit a new PR on top of the current master branch if you still want to include this recipe.

@imciner2 imciner2 closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants