-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient implementation of two_qubit_depolarizing_channel()
#456
Comments
@Roger-luo, @jlbosse: I'm taking a look at this. I think I know what the QuEST code is doing. |
Great! Do you want to explain it here or, if you understand the Yao codebase well enough, open a pull request with a Yao implementation? |
QuEST in general has a number of noise functions. Where are we with these types of implementations in Yao? |
There are a couple of standard error channels already implemented, see e.g. here. And if the channel you are interested in has unitary Kraus operators, you can use the |
@jlbosse @fieldofnodes: I didn't work out the QuEST implementation. It introduces extra parameters that weren't obvious. I emailed the author a few weeks ago. They haven't yet written back. |
@atomgardner I have thought about bringing QuEST in to Julia, then I found
No Idea if they work still, only found them yesterday. I am working directly with QuEST here: https://github.com/ediparquantum/MBQC I am sure you have seen this but I thought I would paste there documentation page on Decoherence here: There are several custom structures used in QuEST, I think since they aim to make the library hardware agnostic it has to do a lot of behind the scenes stuff. Most of the noise seems to be some sort of Kraus operator and some direct density matrix algebra, but I have not dived to deep into that layer of code. |
If you are wrapping QuEST binary in Julia, I recommend continuing the some of the previous work bringing QuEST binary into BB first. I had an early attempt, and there is a later one as well |
The implementation of
two_qubit_depolarizing_channel()
from #455 is not the very efficient. QuEST seems to have a more efficient implementation of that channel here.The text was updated successfully, but these errors were encountered: