[Go]: migrate to gonum.org/v1 packages #55
Conversation
acxz
force-pushed
the
perf-gonum
branch
2 times, most recently
from
dd54afd
to
fd5ed47
Compare
|
Nice work! Looks good to me. |
|
@MilesCranmer do you know who to ping to get these PRs merged in? There are quite a few of them and I'd like to check them off. |
|
I think @DilumAluthge @giordano @johnfgibson have write access here but am not sure who else. @StefanKarpinski + @ViralBShah look to have merged the most recent code to the go benchmark but not sure if they have bandwidth. |
|
Yeah I can take a look. @acxz I can give you write access to the repo. Could you review all the outstanding PRs and merge those that are good to go and close others/ask for updates? |
|
@ViralBShah that would be great as I currently have the cycles for keeping up with this repo. At this point, my focus will just be to fix up the existing issues with the codebase and keep it up to date with changes such as syntax. |
|
I've added you. |
|
Looks like it might take a while for github to register to change, I'll confirm tomorrow morning. |
|
You have to accept the invite manually. Did you get an email from GitHub? |
|
As of yet, I have not gotten an email from GitHub. |
|
You should be able to see the invitation in your github account - at github.com/acxz or something like that (on top of the screen). And maybe check that you have the right email on your github account? |
|
Maybe try here: https://github.com/JuliaLang/Microbenchmarks/invitations |
|
I checked and confirmed both my profile and my email. Still nothing, this is quite weird. I got the following error:
|
|
I think the invite had been sent mistakenly to aczx instead of acxz... Check now. |
|
Yep just received it. Thanks! |
|
🤦 That's on me. Thanks for catching that Viral! |
|
CI passes with updated Go changes. Merging in. |
This is to update go tests so that we can get them up and running in the CI.
Supersedes and closes #27