[Go]: migrate to gonum.org/v1 packages #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@btracey @kortschak could you have a look as well? |
kortschak
suggested changes
Aug 5, 2018
perf.go
Outdated
| @@ -40,8 +38,7 @@ func init() { | |||
| //blas64.Use(cgo.Implementation{}) | |||
There was a problem hiding this comment.
This needs to change. There is not cgo.Implementation.
|
Thanks for this. I run the microbenchmark suite on my office desktop computer; I'll test it there in a week when I return from JuliaCon. |
sbinet
added a commit
to sbinet-gonum/gonum
that referenced
this pull request
Aug 6, 2018
This was noticed while adapting JuliaLang/Microbenchmarks#27 to the new Gonum import paths. This CL somewhat clarifies the correct default implementation (pure-Go) used by the various blas{32,64} and cblas{64,128} packages.
sbinet
added a commit
to sbinet-gonum/gonum
that referenced
this pull request
Aug 13, 2018
This was noticed while adapting JuliaLang/Microbenchmarks#27 to the new Gonum import paths. This CL somewhat clarifies the correct default implementation (pure-Go) used by the various blas{32,64} and cblas{64,128} packages.
sbinet
added a commit
to sbinet-gonum/gonum
that referenced
this pull request
Aug 14, 2018
This was noticed while adapting JuliaLang/Microbenchmarks#27 to the new Gonum import paths. This CL somewhat clarifies the correct default implementation (pure-Go) used by the various blas{32,64} and cblas{64,128} packages.
sbinet
added a commit
to gonum/gonum
that referenced
this pull request
Aug 14, 2018
This was noticed while adapting JuliaLang/Microbenchmarks#27 to the new Gonum import paths. This CL somewhat clarifies the correct default implementation (pure-Go) used by the various blas{32,64} and cblas{64,128} packages.
This was referenced Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/gonum/...imports are deprecated and do not see any new improvements.migrate to use the maintained
gonum.org/v1/...imports.