Fix online link detection in entry editor #8514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
koppor
requested changes
Feb 20, 2022
| @@ -22,7 +22,7 @@ | |||
| return files; | |||
| } | |||
|
|
|||
| if (LinkedFile.isOnlineLink(value.trim())) { | |||
| if (!value.trim().startsWith(":") && LinkedFile.isOnlineLink(value.trim())) { | |||
There was a problem hiding this comment.
I think, isOnlineLink should be fixed. The file field can contain a description. In case the description is This is an awesome/somesome file, the method will still break.
Maybe, we should work on a more intuitive file field - see #98 for a discussion.
There was a problem hiding this comment.
I switched to a regex with the condition to only match at the beginning. The contains www was a culprit
There was a problem hiding this comment.
I believe this was originally chose for performance reasons. Can we somehow benchmark this?
There was a problem hiding this comment.
The regex is compiled, I doubt it will be a huge problem.
There was a problem hiding this comment.
Can we remove the `!value.trim().startsWith(":")? part?
It should be working without that check.
* 'fixurllink' of github.com:JabRef/jabref: Fix typo
|
i would like to merge this, as this is otherwise fails for a lot of users |
* upstream/main: Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542) Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e Bump classgraph from 4.8.139 to 4.8.141 (#8535) Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536) issue(8448): allow URL with + sign in entry tabs (#8508) Add initial telemetry development documentation (#8530) Add existing "Remote storage" to index Disable telemetry client due to incompatibilites with jakarta (#8526) Update to jakarta xml everywhere and update PDFbox (#8521) Bump flexmark-ext-gfm-tasklist from 0.62.2 to 0.64.0 (#8515) Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519) Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518) Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
* upstream/main: Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
|
Fix olly's checkstyle... |
Siedlerchr
added a commit
that referenced
this pull request
Mar 7, 2022
…om.puppycrawl.tools-checkstyle-10.0 * upstream/main: Fix online link detection in entry editor (#8514) Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549) Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542)
Siedlerchr
added a commit
that referenced
this pull request
Mar 9, 2022
* upstream/main: Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531) Bump checkstyle from 9.3 to 10.0 (#8544) Fix online link detection in entry editor (#8514) Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549) Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542) Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e Bump classgraph from 4.8.139 to 4.8.141 (#8535) Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536) # Conflicts: # src/test/java/org/jabref/logic/xmp/XmpUtilReaderTest.java
Siedlerchr
added a commit
that referenced
this pull request
Mar 13, 2022
* upstream/main: Update RemoteSetupTest.java, adding eq() function from mockito (#8561) readd encoding after merge Open office refactor finalization (formerly OObranch J cleanup) (#7795) Revert "Refine documentation (#8551)" (#8560) Refine documentation on logging (#8550) Revert "Refine documentation (#8551)" (#8559) Refine documentation (#8551) New Crowdin updates (#8557) New Crowdin updates (#8553) Fix missing metadata in BibDatabaseContext (#8556) Add encoding detection (and pin export to UTF-8) (#8506) Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531) Bump checkstyle from 9.3 to 10.0 (#8544) Fix online link detection in entry editor (#8514) Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8510
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)