Add encoding detection (and pin export to UTF-8) #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no more unused variables "encoding"
# Conflicts: # build.gradle
Siedlerchr
reviewed
Feb 19, 2022
# Conflicts: # src/main/java/module-info.java # src/test/java/org/jabref/logic/xmp/XmpUtilReaderTest.java
Even if it's UTF 8 it returned ISO, probably because it's not having a BOM header so we check for utf8 and utf16 manually
* upstream/main: issue(8448): allow URL with + sign in entry tabs (#8508)
|
Only failing test is the StyleLoader test, but that apparently fails randomly |
* upstream/main: Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531) Bump checkstyle from 9.3 to 10.0 (#8544) Fix online link detection in entry editor (#8514) Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549) Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542) Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e Bump classgraph from 4.8.139 to 4.8.141 (#8535) Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536) # Conflicts: # src/test/java/org/jabref/logic/xmp/XmpUtilReaderTest.java
Siedlerchr
added
the
status: ready-for-review
5 tasks
Siedlerchr
added a commit
that referenced
this pull request
Mar 13, 2022
* upstream/main: Update RemoteSetupTest.java, adding eq() function from mockito (#8561) readd encoding after merge Open office refactor finalization (formerly OObranch J cleanup) (#7795) Revert "Refine documentation (#8551)" (#8560) Refine documentation on logging (#8550) Revert "Refine documentation (#8551)" (#8559) Refine documentation (#8551) New Crowdin updates (#8557) New Crowdin updates (#8553) Fix missing metadata in BibDatabaseContext (#8556) Add encoding detection (and pin export to UTF-8) (#8506) Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531) Bump checkstyle from 9.3 to 10.0 (#8544) Fix online link detection in entry editor (#8514) Add some JavaDoc to Fetchers Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
2 tasks
This was referenced Jun 16, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8238.
This PR adds the feature to detect the encoding of a file. JabRef relies on the
% Encoding:statement of a file. What if that statement is not present? JabRef 5.5 and 5.6 used "UTF-8"; versions before used the one in the user's preferences. Both approaches are not that reliable.The PR also removes the feature of custom encoding for exporting - and inlines "UTF-8" settings (which were distributed throughout the code).
New general preferences:
It looked as follows before:
gi
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)