Fix handling of URL in file field #7347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
Siedlerchr
previously approved these changes
Jan 14, 2021
calixtus
previously approved these changes
Jan 14, 2021
tobiasdiez
reviewed
Jan 14, 2021
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
tobiasdiez
requested changes
Jan 15, 2021
tobiasdiez
added
the
status: changes required
1 task
|
Bug should be resolved. Changes added. Fixes #7359. Added test cases for that, too. |
koppor
removed
the
status: changes required
koppor
changed the title
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
previously approved these changes
Jan 22, 2021
calixtus
previously approved these changes
Jan 24, 2021
|
Well, a test is still failing. |
|
Had to fix a checkstyle issue. Also added a heuristics for Should be ready now. |
calixtus
approved these changes
Jan 24, 2021
tobiasdiez
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
LGTM
Maybe it's time to introduce OnlineLinkedFile, PathLinkedFile and InvalidLinkedFile deriving from an abstract LinkedFile class (as we currently parse a string to a LinkedFile trying to convert strings to paths and urls, but then LinkedFile converts them to a string again...). Something for another time.
1 task
Siedlerchr
added a commit
to koppor/jabref
that referenced
this pull request
Jan 26, 2021
* upstream/master: (217 commits) Fix handling of URL in file field (JabRef#7347) Fix expansion of bracketed expressions in RegExpBasedFileFinder (JabRef#7338) Refactor unlinked files (JabRef#7209) Add pressing enter when the search field is focused as a way to trigger search (JabRef#7377) Upgrade citeproc to 3.x snapshot without graal (JabRef#7370) Fix Exception if no AzureInstrumentationKey is available (JabRef#7373) Update snapcraft source url (JabRef#7372) Fix checkstyle and adjust language GitBook: [master] 3 pages and 32 assets modified Add migration to special field (JabRef#7368) GitBook: [master] 5 pages and 29 assets modified Modify message at the duplicates found dialog (JabRef#7231) Fixes miss-parsed names in `AutomaticPersonsGroup` (JabRef#7228) Fix an issue where the password for a shared SQL database was only remembered if it was the same as the username (JabRef#7364) Fix harvard exporter by changing AuthorsFormatter (JabRef#7355) Bump styfle/cancel-workflow-action from 0.6.0 to 0.7.0 (JabRef#7363) Bump mockito-core from 3.7.0 to 3.7.7 (JabRef#7360) Bump org.beryx.jlink from 2.23.1 to 2.23.2 (JabRef#7361) Bump libreoffice from 7.0.3 to 7.0.4 (JabRef#7362) Export full month name instead of number in ms office (JabRef#7358) ... # Conflicts: # external-libraries.md # src/main/java/module-info.java # src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogViewModel.java
Siedlerchr
added a commit
that referenced
this pull request
Feb 1, 2021
* upstream/master: Bump archunit-junit5-api from 0.15.0 to 0.16.0 (#7407) Bump classgraph from 4.8.98 to 4.8.102 (#7401) Bump archunit-junit5-engine from 0.15.0 to 0.16.0 (#7402) Bump mariadb-java-client from 2.7.1 to 2.7.2 (#7406) Bump org.beryx.jlink from 2.23.2 to 2.23.3 (#7400) Bump checkstyle from 8.39 to 8.40 (#7404) Ignore codecov status for automerge Fixes issue of Changing font size makes font size field too small (#7398) fix "Alt + keyboard shortcuts do not work" (#7379) Fixed invisible file path in the dark theme (#7396) Fix File Filter and some layout issues (#7385) Feature/implement complex queries (#7350) Change format for study definition to yaml (#7126) Fix handling of URL in file field (#7347) Fix expansion of bracketed expressions in RegExpBasedFileFinder (#7338)
5 tasks
1 task
|
For the record: Fixes #6859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test introduced in #7043 raises an exception on Windows, because:is not allowed as path separator.This PR adds a workaround.Alternative:@DisableOnWindowstest annotation. Since we (hopefully) need that only once, we decided for a quick workaround by checking forOS.WINDOWS.