Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add online-link detection to FileFieldParser #7043

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Add online-link detection to FileFieldParser #7043

merged 5 commits into from
Oct 28, 2020

Conversation

Niffler
Copy link
Contributor

@Niffler Niffler commented Oct 25, 2020

Fixes #7032. The FileFieldParser did not detect an URL and created a LinkedFile object with the URL as a local file path, which caused an error when running "Check integrity".

I'm not sure if the unit test is in the right class.
If this change requires a changelog entry, I'm happy to add one.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 26, 2020
@Siedlerchr
Copy link
Member

Thanks for the contribution! LGTM!

calixtus
calixtus requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, however, got one important remark.

src/main/java/org/jabref/logic/importer/util/FileFieldParser.java Show resolved Hide resolved
@Niffler Niffler requested a review from calixtus October 27, 2020 17:01
@Siedlerchr Siedlerchr mentioned this pull request Oct 28, 2020
Closed
5 tasks
@DominikVoigt
Copy link
Contributor

Nice contribution! LGTM!

@Siedlerchr Siedlerchr merged commit 47fd562 into JabRef:master Oct 28, 2020
@Niffler Niffler deleted the fix-issue-7032 branch October 28, 2020 14:07
Siedlerchr added a commit that referenced this pull request Nov 3, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharedbtest
1b15ed5 
* upstream/master:
  Fix 4040 link
  Bump java-diff-utils from 4.8 to 4.9 (#7061)
  Bump bcprov-jdk15on from 1.66 to 1.67 (#7063)
  Bump checkstyle from 8.36.2 to 8.37 (#7064)
  Bump mockito-core from 3.5.15 to 3.6.0 (#7067)
  Bump controlsfx from 11.0.2 to 11.0.3 (#7066)
  Squashed 'src/main/resources/csl-styles/' changes from 5297abd..5c376b8
  add short date formatter (#7039)
  Add awt native open commands (#7037)
  Add online-link detection to FileFieldParser (#7043)
@koppor koppor mentioned this pull request Jan 14, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus Awaiting requested review from calixtus

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra character added to bib field "file" when adding an arXiv article
4 participants
@Niffler @Siedlerchr @DominikVoigt @calixtus