Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-for-issue-4489 #4538

Merged
merged 7 commits into from
Dec 17, 2018
Merged

fix-for-issue-4489 #4538

merged 7 commits into from
Dec 17, 2018

Conversation

nrmancuso
Copy link
Contributor

@nrmancuso nrmancuso commented Dec 15, 2018 •
edited
Loading

Fix fulltext document linking from Quality menu

@nrmancuso
Copy link
Contributor Author

Ready for review, though I expect that this will need some revision. This issue might have been more complicated than I thought initially.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 15, 2018
Siedlerchr
Siedlerchr reviewed Dec 15, 2018
View reviewed changes
src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java Outdated
@@ -39,6 +43,10 @@
private final BasePanel basePanel;
private final DialogService dialogService;

//Stuff for downloading full texts
private final FulltextFetchers fetcher = new FulltextFetchers(JabRefPreferences.getInstance().getImportFormatPreferences());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to get rid of explicit calling JabRefPreferences., the ideal solution would be pass the ImportFormatPrefernces as parameter in the constructor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And while you are onto this class, you could refactor it to extend the SimpleCommand class (see for example WriteXMP Action)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siedlerchr So, it should not implement the BaseAction interface anymore then, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, replace the base action with SimpleCommand, instead of an action method you have an execute method, it's technically just a different name, the behavior is the same and you can just rename it

Copy link
Contributor Author

@nrmancuso nrmancuso Dec 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siedlerchr BasePanel.java doesn't like that because now the second argument when putting the actions in the map that actions are stored in is no longer a "BaseAction". How should I proceed?

Copy link
Member

@Siedlerchr Siedlerchr Dec 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get rid of that action entry in the action map, look at the setup of the actions in the menus, There should be the SimpleCommand variant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! I think I've got everything fixed up.

Siedlerchr
Siedlerchr reviewed Dec 15, 2018
View reviewed changes
src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java Outdated
@@ -47,8 +55,9 @@ public FindFullTextAction(DialogService dialogService, BasePanel basePanel) {
@Override
public void action() {
BackgroundTask.wrap(this::findFullTexts)
.onSuccess(downloads -> SwingUtilities.invokeLater(() -> downloadFullTexts(downloads)))
.executeWith(Globals.TASK_EXECUTOR);
.onSuccess(downloads -> SwingUtilities.invokeLater(() -> downloadFullTexts(downloads)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you no longer need the swing utitilies call here because you effectively removed the swing code which needed this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Lambdas (and programming in general) are all new to me, I'm still getting used to them. I have replaced this with a simple method reference to downLoadFullTexts. Thanks for the suggestion. I was also able to remove the now unnecessary import of swing also.

Siedlerchr
Siedlerchr requested changes Dec 15, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the code looks good to me, I just have some refactor things which would be nice if you could do this as well.

tobiasdiez
tobiasdiez requested changes Dec 15, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only a few additional remarks.

src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java Outdated
//Download full text
BackgroundTask
.wrap(() -> fetcher.findFullTextPDF(entry))
.onSuccess(url -> addLinkedFileFromURL(result.get(), entry))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you already have the url in Optional<URL> result there is no need for the additional call to fetcher.findFullTextPDF(entry). Simply invoke addLinkedFileFromURL(result.get(), entry) without any wrapper.

src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java Outdated
@@ -39,6 +43,10 @@
private final BasePanel basePanel;
private final DialogService dialogService;

//Stuff for downloading full texts
private final FulltextFetchers fetcher = new FulltextFetchers(JabRefPreferences.getInstance().getImportFormatPreferences());
private final ListProperty<LinkedFileViewModel> files = new SimpleListProperty<>(FXCollections.observableArrayList(LinkedFileViewModel::getObservables));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to me that you only add elements to this list, but never query its contents. In this case, you can probably remove this variable.

src/main/java/org/jabref/gui/externalfiles/FindFullTextAction.java Outdated
files.add(onlineFile);
onlineFile.download();

entry.addFile(newLinkedFile);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you probably need to add the onlineFile.getFile , because otherwise you add just the url to the entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez thanks for all of the great feedback! I should have everything wrapped up by tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasdiez I think I've gotten everything taken care of. Thanks again for the help!

@Siedlerchr
Copy link
Member

Thank you very much for your contribution°!

@Siedlerchr Siedlerchr merged commit 3c87491 into JabRef:master Dec 17, 2018
@nrmancuso
Copy link
Contributor Author

You're welcome!

Siedlerchr added a commit that referenced this pull request Dec 23, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
3e4d135 
* upstream/master:
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541)
  Bump antlr4 from 4.7.1 to 4.7.2 (#4543)
  Fix journal name "Astronomy Journal" to "Astronomical Journal"
  fix-for-issue-4489 (#4538)
  Sorting of read-status isn't working as expected #4521 (#4536)
  Add preselect last used export format in export to clipboard dialog (#4533)
  fixed 4365 put html in clipboard (#4519)
  [WIP] Convert Exporter Customization Dialog to javafx (#4394)
  Fixes #4437 (#4531)
  Bump checkstyle from 8.14 to 8.15 (#4528)

# Conflicts:
#	src/main/java/org/jabref/preferences/PreferencesService.java
Siedlerchr added a commit that referenced this pull request Dec 28, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into portblock
928fd8e 
* upstream/master: (49 commits)
  improve styling of preferences side menu (#4556)
  Cleanup interfaces (#4553)
  Bump fontbox from 2.0.12 to 2.0.13 (#4552)
  Bump pdfbox from 2.0.12 to 2.0.13 (#4551)
  Bump wiremock from 2.19.0 to 2.20.0 (#4550)
  Fixes that renaming a group did not change the group name in the interface (#4549)
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541)
  Bump antlr4 from 4.7.1 to 4.7.2 (#4543)
  Fix journal name "Astronomy Journal" to "Astronomical Journal"
  fix-for-issue-4489 (#4538)
  Sorting of read-status isn't working as expected #4521 (#4536)
  Add preselect last used export format in export to clipboard dialog (#4533)
  fixed 4365 put html in clipboard (#4519)
  [WIP] Convert Exporter Customization Dialog to javafx (#4394)
  Fixes #4437 (#4531)
  Bump checkstyle from 8.14 to 8.15 (#4528)
  Correct PNAS abbrev. (#4524)
  Create test (#4518)
  ...
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Feb 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from e71363e..e2416fa
4b93e91 
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e2416fa
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Feb 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..e2416fa
351911f 
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e2416fa
github-actions bot pushed a commit that referenced this pull request Feb 2, 2020
Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528
78b8ccd 
c531528 create mcgill9-en.csl, Canadian McGill legal style (#4532)
e2416fa Update clinical-and-experimental-optometry.csl (#4538)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c531528
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request Feb 3, 2020
Squashed 'src/main/resources/csl-styles/' changes from 11e9ac9..c531528
dd46c28 
c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532)
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c531528
github-actions bot pushed a commit to ddunig2/jabref that referenced this pull request Feb 6, 2020
Squashed 'src/main/resources/csl-styles/' changes from 49a1841..e106215
60b2b9b 
e106215 Create annales-de-demographie-historique.csl (JabRef#4512)
4dd974e Create lauterbornia.csl (JabRef#4525)
e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551)
f9cfe40 Add new IOP dependents (JabRef#4549)
daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544)
10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545)
c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532)
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)
e71363e Create geriatrie-et-psychologie-neuropsychiatrie-du-vieillissement.csl (JabRef#4543)
cdd973e APA: Add "personal communication" localization (JabRef#4539)
77bdb6f Create eksploatacja-i-niezawodnosc (JabRef#4531)
7858966 Ready: Update psychological-medicine.csl (JabRef#4536)
264141a Create south-african-actuarial-journal.csl (JabRef#4534)
1fde301 Create pakistan-journal-of-agricultural-sciences.csl (JabRef#4535)
3020eb3 Update hochschule-fur-soziale-arbeit-fhnw.csl (JabRef#4533)
57c8122 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4530)
17c178f Update zeitschrift-fur-internationale-beziehungen.csl (JabRef#4527)
14cf589 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4528)
ca60d6e Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4524)
74c5ae9 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4526)
999e124 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4521)
caabe36 Fix psychiatric services
f50e6f0 Add files via upload (JabRef#4519)
c728658 Create harvard-lancaster-university.csl (JabRef#4520)
11e9ac9 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4511)
101b81c Update agriculturae-conspectus-scientificus.csl (JabRef#4510)
615377e Create international-journal-of-population-data-science.csl (JabRef#4517)
fe7cb69 Update university-of-york-apa.csl
f0c7374 Fix AGLC Subsequents
6a8ec90 More Uni Gottingen fixes
9c0f5c6 Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4460)
22ef83d Update Universitatsmedizin Gottingen
d2f90c9 Create drying-technology.csl (JabRef#4515)
01e339b Create terrorism-and-political-violence.csl (JabRef#4514)
6414c15 Create international-journal-of-hyperthermia.csl (JabRef#4513)
f80b38c Create Sciences Po - Ecole doctorale (note, French) (JabRef#4486)
6a22929 Update instituto-brasileiro-de-informacao-em-ciencia-e-tecnologia-abn… (JabRef#4508)
19c89f5 Create citation-compass-apa-note.csl (JabRef#4500)
fe72590 Chicago fixes & add no-ibid variant (JabRef#4503)
d602477 Update agriculturae-conspectus-scientificus.csl (JabRef#4505)
8a8911b Create mediterranean-journal-of-chemistry.csl (JabRef#4506)
ce77b28 Create conservation-and-society.csl (JabRef#4507)
25a5092 Add IMS journals (JabRef#4496)
a39430e Create rmit-university-harvard.csl (JabRef#4504)
830aa7b Update john-benjamins-publishing-company-collective-volumes.csl (JabRef#4444)
43e9216 Create PHBern IVP (JabRef#4427)
a052fd6 Create Publications du Groupe d'anthropologie et d'archéologie funéra… (JabRef#4499)
a7e12e1 Further improve legal cites for BJPS (JabRef#4497)
744a507 Update agriculturae-conspectus-scientificus.csl (JabRef#4498)
bfffaed APA: Fix sort order for in-text citations (JabRef#4495)
c48d08b Add "Blood Cancer Discovery" for AACR (JabRef#4492)
f628cb2 Medizinische Fakultät Mannheim - Numerisch (JabRef#4490)
77876a4 Improve legal cites for british-journal-of-political-science (JabRef#4488)
3c0c4ee Create apa-with-abstract.csl (JabRef#4487)
a26fa95 Update afte-journal.csl (JabRef#4489)
a7bf678 Create agriculturae-conspectus-scientificus.csl (JabRef#4491)
bb01625 Make ET&C dependent of CSE (JabRef#4483)
b4418ef Create ahmad-ibrahim-kulliyyah-of-laws-international-islamic-universi… (JabRef#4482)
22872d2 APA: Use "et al." in Dutch (JabRef#4484)
5f6c080 Update weed-research.csl (JabRef#4485)
b2fbe15 APA 7th edition (JabRef#4419)
c236ade Create BFCN.csl (JabRef#4481)
25d40cd Update iso690-full-note-cs.csl (JabRef#4480)
5de3904 Update budownictwo-i-architektura-pl.csl (JabRef#4479)
9d9c1da Add files via upload (JabRef#4478)
96200b0 Create instituto-alberto-luiz-coimbra-de-pos-graduacao-e-pesquisa-de-… (JabRef#4476)
8aa9cb0 Update APA journal styles (JabRef#4475)
8549afa Update in-text citation for legal_case for BJPS (JabRef#4470)
71c9e4d Update surgical-neurology-international.csl (JabRef#4472)
a9dac17 Create FUNDING.yml
633e864 Create helsingin-yliopisto-teologinen-tiedekunta-teologian-tyyli.csl (JabRef#4303)
8797c01 Create romanian-iso-690-full-note-with-ibid-romanian.csl (JabRef#4465)
c1519e1 Create assosiation-of-firearms-and-toolmark-examiners.csl (JabRef#4468)
c974e30 Update ieee.csl (JabRef#4467)
a1b7386 Update stale.yml (JabRef#4466)
db549dd Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-ser… (JabRef#4462)
2822437 Update .travis.yml (JabRef#4463)
3d72c62 WIP: Adding deprecation notice to DIN1505-2 saying it has been superseded by ISO 690 (JabRef#4454)
1928c2b Fix links after KI update
fad65b7 Turn Kidney International into AMA dependent
6357af5 Update association-for-computing-machinery.csl (JabRef#4459)
eab02ea Create berlin-school-of-economics-and-law-international-marketing-man… (JabRef#3774)
a3e3d97 One more metadata fix
e7d5071 Some Sheldon metadata fixes
3ad4260 Create jurnal-sains-farmasi-dan-klinis.csl (JabRef#4455)
46370dc Add "AIMS Press" journals (JabRef#4458)
57fca07 Update association-for-computing-machinery.csl (JabRef#4456)
6fa90ed Add "Muséum national d'Histoire naturelle" journal styles (JabRef#4457)
7faf0b0 Bundle update
e3c1f85 Create cryptogamie, bryologie (JabRef#4350)
525bba5 Create iso690-full-note-cs.csl (JabRef#4414)
932fad5 Create iso690-author-date-de.csl (JabRef#4344)
ab23108 Create mbts-fullnote-bibliography.csl (JabRef#4363)
c163008 Create associacao-brasileira-de-normas-tecnicas-ibict-full.csl (JabRef#4202)
5586bbc Create associacao-brasileira-de-normas-tecnicas-ibict-initials.csl (JabRef#4203)
483efcb Update ruhr-universitat-bochum-lehrstuhl-fur-industrial-sales-and-service-engineering.csl (JabRef#4442)
92f437d Create independent style for molecular-nutrition-and-food-research.csl… (JabRef#4342)
0d7f481 Update taylor-and-francis-council-of-science-editors-author-date.csl (JabRef#4385)
2b2786b Create ritid-timarit-hugvisindastofnunnar.csl (JabRef#4315)
9534999 Create jsbm.csl (JabRef#4371)
b390657 Changed term on access macro, added rules for bill (JabRef#4407)
95c24f9 Create ecausp-abnt.csl (JabRef#4420)
66ca962 Reindent/reorder
91fefee Create materials-express.csl (JabRef#4445)
ea5d50b Create institut-catholique-de-paris.csl (JabRef#4450)
a4c07e2 Create institut-catholique-de-paris.csl (JabRef#4374)
8a17ae0 Update canadian-geotechnical-journal.csl (JabRef#4447)
7165db0 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4448)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: e106215
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request Feb 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from e71363e..9e81857
ed98896 
9e81857 Update marine-ornithology.csl (JabRef#4566)
938537e Update government-and-opposition.csl (JabRef#4564)
50d0635 Update annales-de-demographie-historique.csl (JabRef#4560)
42b54d9 Create marine-ornithology.csl (JabRef#4559)
eff41bb Create dermatology-online.csl (JabRef#4558)
3911696 Update journal-of-forensic-sciences.csl (JabRef#4554)
059ea33 Small capitals and categories (JabRef#4556)
97b8c84 Create CSL Styles: estudios_hispanicos.csl (JabRef#4557)
57e0f9d Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4552)
f481ea3 Create ipb-ppki-3.csl (JabRef#4550)
899d302 Update journal-of-neolithic-archaeology.csl (JabRef#4553)
e106215 Create annales-de-demographie-historique.csl (JabRef#4512)
4dd974e Create lauterbornia.csl (JabRef#4525)
e5277ae Update sciences-po-ecole-doctorale-note-french.csl (JabRef#4551)
f9cfe40 Add new IOP dependents (JabRef#4549)
daff985 Create brazilian-journal-of-veterinary-research-and-animal-science.csl (JabRef#4544)
10c6fa8 Update ens-de-lyon-centre-d-ingenierie-documentaire.csl (JabRef#4545)
c531528 create mcgill9-en.csl, Canadian McGill legal style (JabRef#4532)
e2416fa Update clinical-and-experimental-optometry.csl (JabRef#4538)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 9e81857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrmancuso @Siedlerchr @tobiasdiez