Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some bugs in preference->Entry table columns #4437

Closed
springzfx opened this issue Oct 30, 2018 · 9 comments
Closed

Some bugs in preference->Entry table columns #4437

springzfx opened this issue Oct 30, 2018 · 9 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. preferences ui

Comments

@springzfx
Copy link

preference->Entry table columns

  1. The Field name is not editable
  2. The value in Field name is not identical with table header
  3. The two buttons in bottom looks the same
  4. Column width is float which is not compatible with jabref-4.3.1.

image

table header:
image
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs ui preferences good first issue An issue intended for project-newcomers. Varies in difficulty. labels Oct 30, 2018
@tobiasdiez
Copy link
Member

tobiasdiez commented Oct 30, 2018 •
edited
Loading

Moreover, the column width should be completely removed from the preferences since columns can now comfortably resized directly in the main view.

@morganlovato
Copy link
Contributor

morganlovato commented Oct 30, 2018 •
edited
Loading

I have a group for a school project and we would like to contribute to this issue, is it available?

@tobiasdiez
Copy link
Member

@morganlovato Sure, feel free to work on this issue! Also have a look at our contribution guide and drop by in our developer chat if you have questions!

@Siedlerchr Siedlerchr mentioned this issue Nov 4, 2018
Closed
@hsvia hsvia mentioned this issue Nov 4, 2018
Closed
@Siedlerchr
Copy link
Member

Agree with @tobiasdiez The preferences option should be completely removed, this should already be sufficient as there is already a change listener present in PersistenceVisualStateTable which stores the width

morganlovato added a commit to morganlovato/jabref that referenced this issue Dec 6, 2018
@morganlovato
Fixes JabRef#4437
0918c1d 
Changed the sizes of buttons "Update to current column widths" and "Update to current column order"

There is still more to fix in this issue:
The Field name is not editable
The value in Field name is not identical with table header
@tobiasdiez
Copy link
Member

tobiasdiez commented Dec 6, 2018 •
edited
Loading

The buttons now have the correct size thanks to @morganlovato.

However, the other issues remain:

  • The Field name is not editable
  • The value in Field name is not identical with table header
  • Remove everything related to the width from the preference dialog (but not from the preference themselves)

@tobiasdiez tobiasdiez reopened this Dec 6, 2018
@aman-coolinc1
Copy link
Contributor

Hi,
Remove everything related to the width from the preference dialog (but not from the preference themselves)

Do you mean we should remove these things from the dialog
image

@aman-coolinc1
Copy link
Contributor

image

@Siedlerchr
Copy link
Member

@aman-coolinc1 Yes, exactly the things you marked. This is because, you can change the column size directly in the main table,

@rachelwu21 rachelwu21 mentioned this issue Dec 20, 2018
Merged
6 tasks
Siedlerchr added a commit that referenced this issue Dec 23, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
3e4d135 
* upstream/master:
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541)
  Bump antlr4 from 4.7.1 to 4.7.2 (#4543)
  Fix journal name "Astronomy Journal" to "Astronomical Journal"
  fix-for-issue-4489 (#4538)
  Sorting of read-status isn't working as expected #4521 (#4536)
  Add preselect last used export format in export to clipboard dialog (#4533)
  fixed 4365 put html in clipboard (#4519)
  [WIP] Convert Exporter Customization Dialog to javafx (#4394)
  Fixes #4437 (#4531)
  Bump checkstyle from 8.14 to 8.15 (#4528)

# Conflicts:
#	src/main/java/org/jabref/preferences/PreferencesService.java
Siedlerchr added a commit that referenced this issue Dec 28, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into portblock
928fd8e 
* upstream/master: (49 commits)
  improve styling of preferences side menu (#4556)
  Cleanup interfaces (#4553)
  Bump fontbox from 2.0.12 to 2.0.13 (#4552)
  Bump pdfbox from 2.0.12 to 2.0.13 (#4551)
  Bump wiremock from 2.19.0 to 2.20.0 (#4550)
  Fixes that renaming a group did not change the group name in the interface (#4549)
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  Bump applicationinsights-core from 2.2.1 to 2.3.0 (#4541)
  Bump antlr4 from 4.7.1 to 4.7.2 (#4543)
  Fix journal name "Astronomy Journal" to "Astronomical Journal"
  fix-for-issue-4489 (#4538)
  Sorting of read-status isn't working as expected #4521 (#4536)
  Add preselect last used export format in export to clipboard dialog (#4533)
  fixed 4365 put html in clipboard (#4519)
  [WIP] Convert Exporter Customization Dialog to javafx (#4394)
  Fixes #4437 (#4531)
  Bump checkstyle from 8.14 to 8.15 (#4528)
  Correct PNAS abbrev. (#4524)
  Create test (#4518)
  ...
@tobiasdiez tobiasdiez mentioned this issue Jan 5, 2019
Closed
tobiasdiez pushed a commit that referenced this issue Jan 12, 2019
@rachelwu21 @tobiasdiez
Fix for Issue #4437 - Some bugs in preference->Entry table columns (#…
f3d03a8 
…4546)

* Changed gui.preference.TableColumnTab.java. But some files I haven't touched are showing errors.

* made preferences->Entry table columns editable

* style changes

* removed obsolete localization key

* adding rows also adds widths

* check consistent endstate if change columns from GUI

* changing columns from GUI

* check consistent endstate if change columns from GUI

* removed redundant tableRows

* removed unnecessary updates to colsetup

* CHANGELOG updated

* removed UpdateWidthsAction and associated stuff
@tobiasdiez
Copy link
Member

Thanks to @rachelwu21, this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Jan 14, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
ce5daaa 
* upstream/master:
  update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one
  Update journalList.txt
  Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546)
Siedlerchr added a commit that referenced this issue Jan 20, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into editStringsjavafx
3fa8648 
* upstream/master: (583 commits)
  update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one
  Update journalList.txt
  Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546)
  Don't set column sort type at startup (#4577)
  Add uncaught exception message (#4565)
  Converts integrity check dialog to JavaFX (#4559)
  Do not extract file ending from Urls (#4547)
  Bump checkstyle from 8.15 to 8.16 (#4562)
  Bump xmpbox from 2.0.12 to 2.0.13 (#4561)
  Delete the deprecated BibEntry Constructor (#4560)
  Refactor BibEntry deprecated method (#4554)
  Added extra stats to be sent with MrDLib recommendations (#4452)
  improve styling of preferences side menu (#4556)
  Cleanup interfaces (#4553)
  Bump fontbox from 2.0.12 to 2.0.13 (#4552)
  Bump pdfbox from 2.0.12 to 2.0.13 (#4551)
  Bump wiremock from 2.19.0 to 2.20.0 (#4550)
  Fixes that renaming a group did not change the group name in the interface (#4549)
  Bump applicationinsights-logging-log4j2 from 2.2.1 to 2.3.0 (#4540)
  Bump antlr4-runtime from 4.7.1 to 4.7.2 (#4542)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/model/entry/BibtexString.java
Siedlerchr added a commit that referenced this issue Jan 27, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into jdk9
0a54822 
* upstream/master: (229 commits)
  Try to fix not on FX thread for search and autocomplete (#4618)
  Convert DuplicateResolverDialog to javafx (#4601)
  Fix for BibTex source tab parsing issue if field contains {} (#4581)
  Convert OO/LO SidePanel to javafx (#4341)
  Convert "Customize importer" dialog to JavaFX (#4608)
  Convert "From Aux file" dialog to JavaFX (#4607)
  Convert "Show preferences" dialog to JavaFX (#4605)
  Fix not on FX thread exception
  Force javafx to run thread (#4604)
  Convert new version dialog to JavaFX (#4602)
  Add a variable to track the change in preview style (#4587)
  Solution for submitting dialog with Ctrl + Enter (#4496) (#4592)
  Bump mysql-connector-java from 8.0.13 to 8.0.14 (#4599)
  Fix overlapping font in id entry type (#4595)
  update jfoenix and gradle plugins Replace outdated transformer log4j2 with official new one
  Update journalList.txt
  Fix for Issue #4437 - Some bugs in preference->Entry table columns (#4546)
  Don't set column sort type at startup (#4577)
  Add uncaught exception message (#4565)
  Converts integrity check dialog to JavaFX (#4559)
  ...

# Conflicts:
#	build.gradle
#	src/main/java/org/jabref/gui/FindUnlinkedFilesDialog.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java
#	src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java
#	src/main/java/org/jabref/gui/openoffice/CitationManager.java
#	src/main/java/org/jabref/gui/openoffice/OOBibBase.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java
#	src/main/java/org/jabref/gui/openoffice/OpenOfficeSidePanel.java
@kbarros kbarros mentioned this issue May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. preferences ui
Projects
Bugs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Siedlerchr @tobiasdiez @aman-coolinc1 @springzfx @morganlovato