Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional "Cancel" and "VSCode" icon #4069

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Additional "Cancel" and "VSCode" icon #4069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06c878
Add VSCode and Cancel icons. Remove lcd antialiasing for buttons.
halirutan Jun 1, 2018
c0553f9
Completely remove explicit font aliasing from icons
tobiasdiez Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/jabref/gui/Base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@
the text is always vertically centered within the bounds. Based on
the cap height of the text. */
-fx-bounds-type: logical_vertical_center;
/* Enable LCD text rendering */
-fx-font-smoothing-type: lcd;
}

.tooltip {
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/jabref/gui/icon/JabRefMaterialDesignIcon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ public enum JabRefMaterialDesignIcon implements GlyphIcons {
COPY("\ue909"),
PASTE("\ue90a"),
SET_CENTER("\ue90b"),
SET_ALL("\ue90c");
SET_ALL("\ue90c"),
VSCODE("\ue90d"),
CANCEL("\ue90e");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we could have reused the original material design font without copy and pasting and icon? Let's see, how I can include the new icon, because constructor of JabRefIcon needs a MaterialDesignIcon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor This is on the maintable-beta branch...there JabRefIcon is an interface.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor That was a design-flaw I fixed for the maintable branch. It basically only needs to implement the GlyphIcons interface. In essence it was a more or less simple refactoring and now the JabRefIcons constructor can take both our Icons and MD icons. Look at the org.jabref.gui.icon package on the maintable branch. Maybe you can cherry pick it somehow.



private final String unicode;
Expand Down
Binary file modified src/main/resources/fonts/JabRefMaterialDesign.ttf
View file
Open in desktop
Binary file not shown.