Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional "Cancel" and "VSCode" icon #4069

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

halirutan
Copy link
Collaborator

In addition to the new icons, I have removed the lcd antialiasing for icons. We discussed several times that this setting makes icons crispy on Linux while it doesn't seem to have a major effect on other operating systems.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@halirutan halirutan mentioned this pull request Jun 1, 2018
6 tasks
@tobiasdiez tobiasdiez merged commit 20920d9 into maintable-beta Jun 1, 2018
@tobiasdiez tobiasdiez deleted the feature/additionalIcons branch June 1, 2018 07:37
SET_ALL("\ue90c");
SET_ALL("\ue90c"),
VSCODE("\ue90d"),
CANCEL("\ue90e");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we could have reused the original material design font without copy and pasting and icon? Let's see, how I can include the new icon, because constructor of JabRefIcon needs a MaterialDesignIcon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor This is on the maintable-beta branch...there JabRefIcon is an interface.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor That was a design-flaw I fixed for the maintable branch. It basically only needs to implement the GlyphIcons interface. In essence it was a more or less simple refactoring and now the JabRefIcons constructor can take both our Icons and MD icons. Look at the org.jabref.gui.icon package on the maintable branch. Maybe you can cherry pick it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants