Split up some larger CI/tox steps into separate jobs #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
lpetre
force-pushed
the
less_tox
branch
3 times, most recently
from
198f669
to
9395770
Compare
Merged
👍 I was able to move the copy/pasta into a local action file, phew! |
lpetre
force-pushed
the
less_tox
branch
6 times, most recently
from
df87d5b
to
6c72869
Compare
Actually that didn't work at all. The composite run actions doesn't support Interesting thread here: actions/runner#646 (comment) Including this gem from June 2021:
I will revisit the copy/pasta when uses is supported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This takes the runtime of the CI from ~8 minutes to <5 mins.
There is some unfortunate duplication, and I wish
needscould depend on one matrix configuration.Otherwise I'm very happy with this change.
This also enables me to ship windows testing, as I don't rely on tox anymore.
Test Plan
See https://github.com/lpetre/LibCST/actions/runs/1121624876