Windows CI support #505
Merged
Windows CI support #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks like one of the windows tests are failing: tox-dev/tox#2077 |
lpetre
force-pushed
the
windows_fix
branch
4 times, most recently
from
3586375
to
1e3a791
Compare
|
I've rebased this onto #511 to work around the tox+windows-latest issue |
|
Closing this, will reopen when #511 is merged |
zsol
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've added windows testing to the github action CI. Some tests fail, so I've updated the _calculate_module method to use PurePath better than before.
Test Plan
See CI run