-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-2206] External DNS and Network Plugin Support #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test out the new submodule * Update providers * Update all providers, might as well * keycloak needs to stay at 4.0.1 * Remove the version constraint on submodule * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Updated module * Update README.md * Remove cluster-manager and update cluster module * Updated module
* Standardized k8s_version variable name, set default to 1.27 * Added helm values to crds/pre-reqs for azure * Added default_node_pool labels * Use index for argo-github-repo * Update the cluster module to take labels on default node pool * retention_days should be between 30-730 * Fix retention policy for diagnostics * Removed metrics section of the cluster module * Make sure that we wait for KEDA to come up before we create the argo application * Updating the cluster module to revert the metrics change in 3.1.2 * Added annotation to ingress-nginx controller * Removed space * Removed smoketest hardcoded values from Azure * Remove cluster manager from azure * Removed cluster manager output
* Increase node size for azurite * x marks the spot
…e (crunchy instances = az count) (#194) * Using new module for cluster, node_group_multi_az does something again * Remove redundant multi-az variable * update cluster module * reduced the number of cidrs for the reduced azs * cluster can have multi az but the node groups stay in single az? * Fix how multi-az is set * Don't delete the allow_access security group yet
* [DOP-1861] Changes to allow using a static certificate. * [DOP-1861] Fix variable refs. * [DOP-1861] adjust indenting for monitoring kube_prometheus_stack_values. * [DOP-1861] adjust monitoring values. * [DOP-1861] adjust k8s ingress block position. * [DOP-1861] adjust secret name for runtime scanner if using a static ssl cert * [DOP-1861] Change k8s dashboard ingress indent * [DOP-1861] Update entire oauth-proxy block. * [DOP-1861] update runtime scanner to allow using a static certificate. * [DOP-1861] disable external dns when using a static ssl certificate * [DOP-1861] update auth-realm annotation for runtime scanner ingress.
#272) * Added support for private_dns_zone_id to be passed in, cluster_outbound_type and private_cluster_public_fqdn_enabled options * Pass in the SKU tier * Default to system assigned private dns zone id --------- Co-authored-by: Andrey Chmykh <andrey.chmykh@indico.io>
NathanOkolita
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.