[DOP-1869] Azurite scheduling fix #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihrc
approved these changes
Sep 16, 2023
ashmuck
added a commit
that referenced
this pull request
Aug 15, 2024
* [DOP-1801][DOP-1742] Spot fix (#173) * Test out the new submodule * Update providers * Update all providers, might as well * keycloak needs to stay at 4.0.1 * Remove the version constraint on submodule * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Updated module * Update README.md * Remove cluster-manager and update cluster module * Updated module * [DOP-1822][DOP-1823][DOP-1828] Cluster version and az helm values (#172) * Standardized k8s_version variable name, set default to 1.27 * Added helm values to crds/pre-reqs for azure * Added default_node_pool labels * Use index for argo-github-repo * Update the cluster module to take labels on default node pool * retention_days should be between 30-730 * Fix retention policy for diagnostics * Removed metrics section of the cluster module * Make sure that we wait for KEDA to come up before we create the argo application * Updating the cluster module to revert the metrics change in 3.1.2 * Added annotation to ingress-nginx controller * Removed space * Removed smoketest hardcoded values from Azure * Remove cluster manager from azure * Removed cluster manager output * [DEV-11062][DOP-1847] Update azure readapi to use azure-storage-key secret (#176) * [DOP-1811] Enable diagnostic settings export to sentinel. (#179) * [DOP-1869] Azurite scheduling fix (#182) * Increase node size for azurite * x marks the spot * [DOP-1873] Changes to allow specifying static domain name. (#185) * Var should be local (#188) * [DOP-1888] Removed the annotation for readapi proxy sidecar (#190) * [DOP-1880] Default azs to 2 and allow number of azs to be configurable (crunchy instances = az count) (#194) * Using new module for cluster, node_group_multi_az does something again * Remove redundant multi-az variable * update cluster module * reduced the number of cidrs for the reduced azs * cluster can have multi az but the node groups stay in single az? * Fix how multi-az is set * Don't delete the allow_access security group yet * [DOP-1861] Changes to allow using a static SSL certificate in AWS (#191) * [DOP-1861] Changes to allow using a static certificate. * [DOP-1861] Fix variable refs. * [DOP-1861] adjust indenting for monitoring kube_prometheus_stack_values. * [DOP-1861] adjust monitoring values. * [DOP-1861] adjust k8s ingress block position. * [DOP-1861] adjust secret name for runtime scanner if using a static ssl cert * [DOP-1861] Change k8s dashboard ingress indent * [DOP-1861] Update entire oauth-proxy block. * [DOP-1861] update runtime scanner to allow using a static certificate. * [DOP-1861] disable external dns when using a static ssl certificate * [DOP-1861] update auth-realm annotation for runtime scanner ingress. * [DOP-1861] Changes to allow specifying static domain name in azure. (#186) * [DOP-1922] Update nvidia-device-plugin config (#196) * Hardcoded some values to connect to the cluster * Updated token again * Updated the token again * imported aws-auth back in * Added ability for custom cluster issuer * Added ability for custom cluster issuer * Allow for network plugin mode variable * Pass in the network plugin mode * Added network mode * Remove pipe * allow disabling external-dns and using private dns * Added support for private_dns_zone_id to be passed in, cluster_outbou… (#272) * Added support for private_dns_zone_id to be passed in, cluster_outbound_type and private_cluster_public_fqdn_enabled options * Pass in the SKU tier * Default to system assigned private dns zone id --------- Co-authored-by: Andrey Chmykh <andrey.chmykh@indico.io> * fixed bad merge * Update dns.tf * Update outputs.tf * Updated duplicate vairables * Update monitoring.tf * Merge conflicts * Update monitoring.tf * Don't create CAA with private fqdn * or * Update aws_specific_modules.tf * Update acm.tf * Update ipa.tf * Update ipa.tf * Update ipa.tf * Update main.tf * Update README.md * Update monitoring.tf * Update user_vars.auto.tfvars * Update README.md * Update variables.tf * Update k8s_dashboard.tf * Update variables.tf * Update variables.tf * Delete backend.tf * Update main.tf * Update main.tf * Update k8s_dashboard.tf * Added vars for dns_service_ip and docker_bridge_cidr * Added service_cidr variable * Resolved merge error * Add images for all external-secrets images * Actually add image values * Fix some dns zone stuff * Add private_dns annotations * Monitoring fix was wrong * need file, not string * Updated again * Forgot colon * Updated to add azurerm_role_assignment * Updates * purge resource group on delete (issue with log group * worng role --------- Co-authored-by: Andrey Chmykh <andrey.chmykh@indico.io> Co-authored-by: Nathan Okolita <Nathan.Okolita@gmail.com> Co-authored-by: indico-devops-sa <andrey.chmykh@indicodata.ai>
NathanOkolita
added a commit
that referenced
this pull request
Sep 5, 2024
…nt (#312) * [DOP-1801][DOP-1742] Spot fix (#173) * Test out the new submodule * Update providers * Update all providers, might as well * keycloak needs to stay at 4.0.1 * Remove the version constraint on submodule * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Update module for cluster * Updated module * Update README.md * Remove cluster-manager and update cluster module * Updated module * [DOP-1822][DOP-1823][DOP-1828] Cluster version and az helm values (#172) * Standardized k8s_version variable name, set default to 1.27 * Added helm values to crds/pre-reqs for azure * Added default_node_pool labels * Use index for argo-github-repo * Update the cluster module to take labels on default node pool * retention_days should be between 30-730 * Fix retention policy for diagnostics * Removed metrics section of the cluster module * Make sure that we wait for KEDA to come up before we create the argo application * Updating the cluster module to revert the metrics change in 3.1.2 * Added annotation to ingress-nginx controller * Removed space * Removed smoketest hardcoded values from Azure * Remove cluster manager from azure * Removed cluster manager output * [DEV-11062][DOP-1847] Update azure readapi to use azure-storage-key secret (#176) * [DOP-1811] Enable diagnostic settings export to sentinel. (#179) * [DOP-1869] Azurite scheduling fix (#182) * Increase node size for azurite * x marks the spot * [DOP-1873] Changes to allow specifying static domain name. (#185) * Var should be local (#188) * [DOP-1888] Removed the annotation for readapi proxy sidecar (#190) * [DOP-1880] Default azs to 2 and allow number of azs to be configurable (crunchy instances = az count) (#194) * Using new module for cluster, node_group_multi_az does something again * Remove redundant multi-az variable * update cluster module * reduced the number of cidrs for the reduced azs * cluster can have multi az but the node groups stay in single az? * Fix how multi-az is set * Don't delete the allow_access security group yet * [DOP-1861] Changes to allow using a static SSL certificate in AWS (#191) * [DOP-1861] Changes to allow using a static certificate. * [DOP-1861] Fix variable refs. * [DOP-1861] adjust indenting for monitoring kube_prometheus_stack_values. * [DOP-1861] adjust monitoring values. * [DOP-1861] adjust k8s ingress block position. * [DOP-1861] adjust secret name for runtime scanner if using a static ssl cert * [DOP-1861] Change k8s dashboard ingress indent * [DOP-1861] Update entire oauth-proxy block. * [DOP-1861] update runtime scanner to allow using a static certificate. * [DOP-1861] disable external dns when using a static ssl certificate * [DOP-1861] update auth-realm annotation for runtime scanner ingress. * [DOP-1861] Changes to allow specifying static domain name in azure. (#186) * [DOP-1922] Update nvidia-device-plugin config (#196) * Hardcoded some values to connect to the cluster * Updated token again * Updated the token again * imported aws-auth back in * [DOP-2121] Fix FSx lambda python runtime. (#249) * Output the resource group name * Added output * Adjusted vault mount path * Make these conditional * Make these conditional * Make these conditional * Fixed dependencies for loading an existing resource group * Fixed dependencies for loading an existing resource group * Allow for resource group name to be loaded * Allow for resource group name to be loaded * Allow for resource group name to be loaded * Added dependencies * Load the resource * Load the identity * Load the identity * Put back WI as it was * Make WI configurable * Make WI configurable * Make WI configurable * Make WI configurable * Make WI configurable * Include DNS challenge * Create Role Assignments for kubelet when not using workload identity * Create Role Assignments for kubelet when not using workload identity * Added azure_client_id * Added azure_client_id * Use account if present * Use default vault mount path * Default to terraform if no mount path provided * Default to terraform if no mount path provided * Default to terraform if no mount path provided * Default to terraform if no mount path provided * Refactored names to match usage * Variablized sentinel workpace name and resource group name * Leave OIDC on * Allow for passing in of sentinel workspace id * Patch for servicebus * option to load network * Fixed vars for loading network * Allow passing of virutal network name * Pass in subnet name * remove validation * Allow for overrriding the keyvault name * Remove unused files * Updated vars * remove unused var * Use updated version to suport kv name * Allow for use of azure networking (#269) * Use azure networking * Allow for the passing in of the network_plugin * Update tf-smoketest-variables.tf * Added ability for custom cluster issuer * Added ability for custom cluster issuer * Allow for network plugin mode variable * Pass in the network plugin mode * Added network mode * Remove pipe * allow disabling external-dns and using private dns * Added support for private_dns_zone_id to be passed in, cluster_outbou… (#272) * Added support for private_dns_zone_id to be passed in, cluster_outbound_type and private_cluster_public_fqdn_enabled options * Pass in the SKU tier * Default to system assigned private dns zone id --------- Co-authored-by: Andrey Chmykh <andrey.chmykh@indico.io> * fixed bad merge * Update dns.tf * Update outputs.tf * Updated duplicate vairables * Update monitoring.tf * Merge conflicts * Update monitoring.tf * Don't create CAA with private fqdn * or * Update aws_specific_modules.tf * Update acm.tf * Update ipa.tf * Update ipa.tf * Update ipa.tf * Update main.tf * Update README.md * Update monitoring.tf * Update user_vars.auto.tfvars * Update README.md * Update variables.tf * Update k8s_dashboard.tf * Update variables.tf * Update variables.tf * Delete backend.tf * Update main.tf * Update main.tf * Update k8s_dashboard.tf * Added vars for dns_service_ip and docker_bridge_cidr * Added service_cidr variable * Resolved merge error * Add images for all external-secrets images * Actually add image values * Fix some dns zone stuff * Add private_dns annotations * Monitoring fix was wrong * need file, not string * Updated again * Forgot colon * Updated to add azurerm_role_assignment * Updates * purge resource group on delete (issue with log group * worng role * Updated to allow setting aks storage account name * Updated zerossl to pull data from customer-<customer> kv * Update main.tf * Create a user defined identity that allows controlling DNS, and then associate that with the cluster. * use .id instead of principle_id * replacing cluster service principal with created user identity (#310) * Do not create an azurerm_user_assigned_identity unless there is a custom dns zone. Make sure the cluster defaults to a system assigned principle when a custom dns zone is not used. --------- Co-authored-by: Andrey Chmykh <andrey.chmykh@indico.io> Co-authored-by: indico-devops-sa <andrey.chmykh@indicodata.ai> Co-authored-by: Eric Fontana <eric.fontana@indico.io> Co-authored-by: Micah Turner <hhbear14@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase node size for azurite