CHORE: Update dependencies

HMPO · Sep 9, 2020 · 961c446 · 961c446
1 parent d933ee1
commit 961c446
Show file tree

Hide file tree

Showing 8 changed files with 1,292 additions and 945 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,8 +1,8 @@
 language: node_js
 node_js:
-  - "8"
   - "10"
   - "12"
+  - "14"
 notifications:
   email: false
 sudo: false
diff --git a/lib/pdf.js b/lib/pdf.js
@@ -242,8 +242,11 @@ class PDF {
             },
             set width(v) {
                 if (state.width === v) return;
-                if (v === undefined) return state.left = state.right = 0;
-                state.right = state.pageWidth - state.left - v;
+                if (v === undefined) {
+                    state.left = state.right = 0;
+                } else {
+                    state.right = state.pageWidth - state.left - v;
+                }
             },
         };
         return state;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,16 +29,16 @@
     "deep-clone-merge": "^1.5.1",
     "hogan.js": "^3.0.2",
     "pdfkit": "^0.11.0",
-    "underscore": "^1.9.2",
+    "underscore": "^1.11.0",
     "xml2js": "^0.4.23"
   },
   "devDependencies": {
     "chai": "^4.2.0",
-    "eslint": "^6.8.0",
-    "mocha": "^7.1.1",
+    "eslint": "^7.8.1",
+    "mocha": "^8.1.3",
     "npm-run-all": "^4.0.2",
-    "nyc": "^15.0.0",
-    "sinon": "^9.0.1",
+    "nyc": "^15.1.0",
+    "sinon": "^9.0.3",
     "sinon-chai": "^3.5.0"
   },
   "nyc": {
@@ -51,6 +51,6 @@
     "statements": 92,
     "branches": 84,
     "functions": 98,
-    "lines": 95
+    "lines": 94
   }
 }
diff --git a/test/unit/fixtures/example.pdf → test/unit/fixtures/example-node10.pdf b/test/unit/fixtures/example.pdf → test/unit/fixtures/example-node10.pdf
diff --git a/test/unit/fixtures/example-node12.pdf b/test/unit/fixtures/example-node12.pdf
diff --git a/test/unit/fixtures/example-node14.pdf b/test/unit/fixtures/example-node14.pdf
diff --git a/test/unit/lib/spec.generate.js b/test/unit/lib/spec.generate.js
@@ -170,7 +170,8 @@ describe('generate', () => {
 
     it('example pdf render', done => {
         let sourcefilename = path.resolve(__dirname, '..', 'fixtures', 'example.xml');
-        let examplepdf = path.resolve(__dirname, '..', 'fixtures', 'example.pdf');
+        let nodeVersion = process.versions.node.split('.')[0];
+        let examplepdf = path.resolve(__dirname, '..', 'fixtures', 'example-node' + nodeVersion + '.pdf');
         let xml = fs.readFileSync(sourcefilename);
         generate.toBuffer(xml, path.dirname(sourcefilename), (err, buffer) => {
             expect(err).to.be.null;