Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): update dependency string replacement #1420

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Jan 4, 2023

This PR goes together with googleapis/sdk-platform-java#1208 in switching dependency from spring-cloud-gcp-core to spring-cloud-gcp-autoconfigure.

BEGIN_COMMIT_OVERRIDE
chore(codegen): update dependency string replacement
END_COMMIT_OVERRIDE

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmileaf emmileaf marked this pull request as ready for review January 4, 2023 15:16
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping a note here to switch to snapshot version in future.
This needs to have RULES_JVM_EXTERNAL upgrade to 4.5.

@emmileaf emmileaf merged commit b0a541f into main Jan 6, 2023
@emmileaf emmileaf deleted the codegen-autoconfigure-dep branch January 6, 2023 14:41
diegomarquezp pushed a commit that referenced this pull request Jan 20, 2023
This goes together with googleapis/sdk-platform-java#1208 in switching generator dependency from spring-cloud-gcp-core to spring-cloud-gcp-autoconfigure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants