fix(spring): add AutoConfigureAfter annotation #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
emmileaf
added
the
spring
zhumin8
approved these changes
Jan 4, 2023
| @@ -166,6 +166,9 @@ public void visit(ScopeNode scope) { | |||
| @Override | |||
| public void visit(AnnotationNode annotation) { | |||
| annotation.type().accept(this); | |||
| if (annotation.descriptionExprs() != null) { | |||
There was a problem hiding this comment.
Ah, Good catch! I guess we missed this and just got lucky with
@ConditionalOnClass(EchoClient.class)
@EnableConfigurationProperties(EchoSpringProperties.class)
diegomarquezp
approved these changes
Jan 5, 2023
emmileaf
added a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Jan 6, 2023
This goes together with googleapis/sdk-platform-java#1208 in switching generator dependency from spring-cloud-gcp-core to spring-cloud-gcp-autoconfigure.
This was referenced Jan 6, 2023
diegomarquezp
pushed a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Jan 20, 2023
This goes together with googleapis/sdk-platform-java#1208 in switching generator dependency from spring-cloud-gcp-core to spring-cloud-gcp-autoconfigure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
AutoConfigureAfter(GcpContextAutoConfiguration.class)annotation to enforce configuration order. It also makes two related changes to enable this annotation:spring-cloud-gcp-coretospring-cloud-gcp-autoconfigure(ref: #1123), and bumps version to latestImportWriterto account for types introduced by annotation parameters - this change is made in d59b40c, and is copied to main branch in fix(ast): update import generation to cover annotation parameters #1229.