Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing conditions to docker_frontend deploy steps #50

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add missing conditions to docker_frontend deploy steps #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
- ARTIFACTORY_USER
- GITHUB_TOKEN

when_internal_branch: &when_internal_branch
when:
event: [push]
branch: [internal]

steps:
- name: setup
image: ubuntu
Expand All @@ -51,16 +56,28 @@
<<: *build_frontend
environment:
ENVIRONMENT: staging
AMPLITUDE_API_KEY: b46a366c22a2e7fb525ae99c14a693ec

Check failure on line 59 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey 

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as
this risks secrets being leaked and used by either an internal or external malicious adversary. It
is recommended to use environment variables to securely provide credentials or retrieve credentials
from a secure vault or HSM (Hardware Security Module).
Raw output 
Fingerprint: 49f300fd3a637a9e5fc4b9a232edb21f0ae5c87898f4cf02aa5a67662fa04384
Category: CWE-798 Use of Hard-coded Credentials

Check failure on line 59 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey 

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as
this risks secrets being leaked and used by either an internal or external malicious adversary. It
is recommended to use environment variables to securely provide credentials or retrieve credentials
from a secure vault or HSM (Hardware Security Module).
Raw output 
Fingerprint: 49f300fd3a637a9e5fc4b9a232edb21f0ae5c87898f4cf02aa5a67662fa04384
Category: CWE-798 Use of Hard-coded Credentials

- name: build_frontend_production
<<: *build_frontend
environment:
ENVIRONMENT: production
AMPLITUDE_API_KEY: f0b9cf5c530426c3dbacb91e74f009a5

Check failure on line 65 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey 

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as
this risks secrets being leaked and used by either an internal or external malicious adversary. It
is recommended to use environment variables to securely provide credentials or retrieve credentials
from a secure vault or HSM (Hardware Security Module).
Raw output 
Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials

Check failure on line 65 in .drone.yml

View check run for this annotation

Funding Circle Checks / fc-checks/coberos

secret.amplitudeapikey 

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as
this risks secrets being leaked and used by either an internal or external malicious adversary. It
is recommended to use environment variables to securely provide credentials or retrieve credentials
from a secure vault or HSM (Hardware Security Module).
Raw output 
Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials

# Push the staging image, tagged with the branch name. Useful for testing the image in fc-datahub.
- name: docker_frontend_development
<<: *docker_build_config
settings:
context : /drone/src/staging/
dockerfile: /drone/src/staging/docker/datahub-frontend/Dockerfile
tags:
- ${DRONE_BRANCH//\//-}
depends_on:
- build_frontend_staging

- name: docker_frontend_staging
<<: *docker_build_config
<<: *when_internal_branch
settings:
context: /drone/src/staging/
dockerfile: /drone/src/staging/docker/datahub-frontend/Dockerfile
Expand All @@ -71,6 +88,7 @@

- name: docker_frontend_production
<<: *docker_build_config
<<: *when_internal_branch
settings:
context: /drone/src/production/
dockerfile: /drone/src/production/docker/datahub-frontend/Dockerfile
Expand Down
Loading