Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing conditions to docker_frontend deploy steps #50

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

maiarareinaldo
Copy link
Collaborator

Description

Add missing conditions on the docker deploy steps (copied the same .drone.yml configuration that was in the internal branch). This ensures the frontend image is not deployed by dependabot pushed commits.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@fc-infosec-sast
Copy link

❌ SAST Report

Errors (4)

Fingerprint: 49f300fd3a637a9e5fc4b9a232edb21f0ae5c87898f4cf02aa5a67662fa04384
Category: CWE-798 Use of Hard-coded Credentials
Rule ID: secret.amplitudeapikey
Location: .drone.yml [59:26]

  59 |       AMPLITUDE_API_KEY: b46*****c

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).


Fingerprint: 49f300fd3a637a9e5fc4b9a232edb21f0ae5c87898f4cf02aa5a67662fa04384
Category: CWE-798 Use of Hard-coded Credentials
Rule ID: secret.amplitudeapikey
Location: .drone.yml [59:26]

  59 |       AMPLITUDE_API_KEY: b46*****c

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).


Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials
Rule ID: secret.amplitudeapikey
Location: .drone.yml [65:26]

  65 |       AMPLITUDE_API_KEY: f0b*****5

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).


Fingerprint: 0b07064446a811305395d5c97469c8b970ce36fa68f0243bf4744cb9fac1beba
Category: CWE-798 Use of Hard-coded Credentials
Rule ID: secret.amplitudeapikey
Location: .drone.yml [65:26]

  65 |       AMPLITUDE_API_KEY: f0b*****5

A hard-coded credential was detected. It is not recommended to store credentials in source-code, as this risks secrets being leaked and used by either an internal or external malicious adversary. It is recommended to use environment variables to securely provide credentials or retrieve credentials from a secure vault or HSM (Hardware Security Module).


For more details, please check code annotations on the changed files.

To create an exception, follow this guide. For help, join #coberos-help.

Copy link
Collaborator

@harsha-mandadi-4026 harsha-mandadi-4026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maiarareinaldo maiarareinaldo merged commit 61c06c7 into master Feb 12, 2024
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants