Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat: remove uppercase from user menu #101

Merged
merged 1 commit into from
May 6, 2019
Merged

feat: remove uppercase from user menu #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/scss/templates/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@
}
}



.user-menu {
background: $dp-color-white;
border-bottom: 3px solid $dp-border-grey;
Expand All @@ -227,13 +225,14 @@ h5 {
margin: $dp-spaces--lv0;
font-weight: bold;
}

p {
margin: $dp-spaces--lv1 $dp-spaces--lv0 $dp-spaces--lv2;
font-size: $dp-sizing--lvl2;
}

a {
font-size: $dp-sizing--lvl2;
text-transform: uppercase;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix probably breaks anything else. Did you review the history?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not wrong, you have introduced the style in 1356951 #93, could you check if this latest change does not break anything related with original commit or PR? Maybe "PRUEBALO GRATIS" button.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, blame is a very useful git tool, let me know if you want to learn to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este style solo afectaba a lo que arme del panel de notificaciones que no se implemento aun. Era algo para corregir. Antes de que lo implementemos debemos arreglar los links en el panel de notificaciones, el "PRUEBALO GRATIS"

uppercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, blame is a very useful git tool, let me know if you want to learn to use it.

I would like to learn!

color: $dp-color-green;

&:hover {
Expand Down Expand Up @@ -287,6 +286,7 @@ a {
}

.options-user {

li {
border-top: 1px solid $dp-border-grey;
padding: 12px 0;
Expand Down
4 changes: 0 additions & 4 deletions assets/scss/templates/_reportes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
align-items: flex-end;
justify-content: flex-end;
}



}

.report-filters {
Expand Down Expand Up @@ -250,7 +247,6 @@
background: $dp-color-ghostwhite;
margin-bottom: $dp-spaces--lv1;


.text-ranking {
margin:$dp-spaces--lv0;
font-size: $dp-sizing--lvl2;
Expand Down