Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat: remove uppercase from user menu #101

Merged

Conversation

GusBaamonde
Copy link
Contributor

@GusBaamonde GusBaamonde commented May 6, 2019

uppercase_user_menu

@GusBaamonde GusBaamonde merged commit 83d19d5 into FromDoppler:master May 6, 2019
a {
font-size: $dp-sizing--lvl2;
text-transform: uppercase;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix probably breaks anything else. Did you review the history?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not wrong, you have introduced the style in 1356951 #93, could you check if this latest change does not break anything related with original commit or PR? Maybe "PRUEBALO GRATIS" button.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, blame is a very useful git tool, let me know if you want to learn to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este style solo afectaba a lo que arme del panel de notificaciones que no se implemento aun. Era algo para corregir. Antes de que lo implementemos debemos arreglar los links en el panel de notificaciones, el "PRUEBALO GRATIS"

uppercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, blame is a very useful git tool, let me know if you want to learn to use it.

I would like to learn!

@andresmoschini
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants