-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some SonarCloud issues from the complete code analysis #49
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd537d6 - Browse repository at this point
Copy the full SHA cd537d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f3ea7 - Browse repository at this point
Copy the full SHA 37f3ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59c1836 - Browse repository at this point
Copy the full SHA 59c1836View commit details -
Configuration menu - View commit details
-
Copy full SHA for df0fda7 - Browse repository at this point
Copy the full SHA df0fda7View commit details
Commits on Mar 5, 2024
-
introduced a configuration properties file and changed a few things a…
…ccording to SonarCloud suggestions; unfortunately, I broke the JAR execution with this because the resource files are not found anymore when executed from JAR, so WIP;
Configuration menu - View commit details
-
Copy full SHA for bea1219 - Browse repository at this point
Copy the full SHA bea1219View commit details
Commits on Mar 6, 2024
-
Fixed import of resource files via configurations class, also works f…
…rom JAR again now; added IConfiguration interface; added configurations as param in constructor of MainViewController and AboutViewController;
Configuration menu - View commit details
-
Copy full SHA for ef17d27 - Browse repository at this point
Copy the full SHA ef17d27View commit details -
All resource files are imported via paths and file names in configura…
…tion properties file;
Configuration menu - View commit details
-
Copy full SHA for 8910e4e - Browse repository at this point
Copy the full SHA 8910e4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73111a1 - Browse repository at this point
Copy the full SHA 73111a1View commit details -
No more exceptions when a configurations instance is passed as param …
…and not de novo constructed;
Configuration menu - View commit details
-
Copy full SHA for d3d0f7f - Browse repository at this point
Copy the full SHA d3d0f7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 202c390 - Browse repository at this point
Copy the full SHA 202c390View commit details
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 71d9a78 - Browse repository at this point
Copy the full SHA 71d9a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba77f2 - Browse repository at this point
Copy the full SHA 0ba77f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6203b4c - Browse repository at this point
Copy the full SHA 6203b4cView commit details
Commits on Mar 11, 2024
-
Merge branch 'production' into sonar-issues-fix
* production: Fix javadoc Add try-catch-block to sorting method Refine javadoc Add javadoc Fix Spotless requirements Optimize imports Change SortType to boolean Add enums to TableViews Add javadoc Add enum for data model properties Fix javadoc Change sort type to enum of TableColumn # Conflicts: # src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Configuration menu - View commit details
-
Copy full SHA for 5843c12 - Browse repository at this point
Copy the full SHA 5843c12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51a1379 - Browse repository at this point
Copy the full SHA 51a1379View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d9b3d - Browse repository at this point
Copy the full SHA 26d9b3dView commit details -
Encapsulated the custom pagination with suitable page count creation …
…into a separate method;
Configuration menu - View commit details
-
Copy full SHA for 62548b5 - Browse repository at this point
Copy the full SHA 62548b5View commit details -
Separated overview view setting for first structure highlight and jum…
…ping to molecule in molecules tab enabled;
Configuration menu - View commit details
-
Copy full SHA for 2c29323 - Browse repository at this point
Copy the full SHA 2c29323View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5638b8 - Browse repository at this point
Copy the full SHA e5638b8View commit details
Commits on Mar 12, 2024
-
More SonarCloud issues fixes, i.a. throwing specific exceptions in Vi…
…ewToolsManager, making fields in MainMenuBar and FragmentsdataTableView final, adjusting some regex patterns, some manual linting, more documentation on how reflection is used to fill the data tables;
Configuration menu - View commit details
-
Copy full SHA for 39ecbc7 - Browse repository at this point
Copy the full SHA 39ecbc7View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2dc5fd - Browse repository at this point
Copy the full SHA a2dc5fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c911c6 - Browse repository at this point
Copy the full SHA 0c911c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f3702a - Browse repository at this point
Copy the full SHA 8f3702aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4590260 - Browse repository at this point
Copy the full SHA 4590260View commit details
Commits on Mar 14, 2024
-
Fixed bug that items tab was not sortable by name (unmodifiable list …
…in the background);
Configuration menu - View commit details
-
Copy full SHA for dd2f0a3 - Browse repository at this point
Copy the full SHA dd2f0a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89094bc - Browse repository at this point
Copy the full SHA 89094bcView commit details -
Linting and fixing some sonar issues in FragmentationService mostly; …
…introducing <?> operator to define undefined generic type of properties;
Configuration menu - View commit details
-
Copy full SHA for 52f0d09 - Browse repository at this point
Copy the full SHA 52f0d09View commit details
Commits on Mar 15, 2024
-
Fixing sonar complaints and linting in FragmentationTask and all frag…
…mentation algorithm classes;
Configuration menu - View commit details
-
Copy full SHA for 5ca25e7 - Browse repository at this point
Copy the full SHA 5ca25e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04961c0 - Browse repository at this point
Copy the full SHA 04961c0View commit details
Commits on Mar 18, 2024
-
Overhaul of exporter, mostly exception treatment (more is passed on t…
…o export thread now, so that it fails properly) and csv export methods return list of faulty molecules now as well;
Configuration menu - View commit details
-
Copy full SHA for 6eaba95 - Browse repository at this point
Copy the full SHA 6eaba95View commit details
Commits on Mar 19, 2024
-
Fixed bug in items tab PDF export, number of fragments in header was …
…not correct but same as number of molecules;
Configuration menu - View commit details
-
Copy full SHA for bdc12be - Browse repository at this point
Copy the full SHA bdc12beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3224b7c - Browse repository at this point
Copy the full SHA 3224b7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a45bb63 - Browse repository at this point
Copy the full SHA a45bb63View commit details -
Changed CSV export separator char from being set directly to an enum …
…constant defining the character;
Configuration menu - View commit details
-
Copy full SHA for c0fc480 - Browse repository at this point
Copy the full SHA c0fc480View commit details -
Configuration menu - View commit details
-
Copy full SHA for b944857 - Browse repository at this point
Copy the full SHA b944857View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b61c2d - Browse repository at this point
Copy the full SHA 9b61c2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9daa33f - Browse repository at this point
Copy the full SHA 9daa33fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ae13f9 - Browse repository at this point
Copy the full SHA 7ae13f9View commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 493d861 - Browse repository at this point
Copy the full SHA 493d861View commit details -
Configuration menu - View commit details
-
Copy full SHA for c18817e - Browse repository at this point
Copy the full SHA c18817eView commit details -
Started working on a new custom property to wrap the language-specifi…
…c display name of an enum constant; prepared the property-using classes like fragmenters, settings container, and view tools for its usage, i.e. no enum.valueof() calls anymore;
Configuration menu - View commit details
-
Copy full SHA for 4af7a03 - Browse repository at this point
Copy the full SHA 4af7a03View commit details
Commits on Mar 21, 2024
-
Added SimpleIDisplayEnumConstantProperty as new JavaFX property that …
…wraps an enum constant with associated display name and tooltip to be used in the GUI; started replacing SimpleEnumConstantNameProperty settings with the new property;
Configuration menu - View commit details
-
Copy full SHA for d8f1847 - Browse repository at this point
Copy the full SHA d8f1847View commit details
Commits on Mar 22, 2024
-
Replaced all SimpleEnumConstantNameProperty settings with SimpleIDisp…
…layEnumConstantProperty settings; implemented a central method for tooltip generation with max width and text wrap;
Configuration menu - View commit details
-
Copy full SHA for e494708 - Browse repository at this point
Copy the full SHA e494708View commit details
Commits on Mar 25, 2024
-
Updated spotless; moved openFilePathInExplorer() to FileUtil; overhau…
…l of preferences; general linting;
Configuration menu - View commit details
-
Copy full SHA for 9a3d613 - Browse repository at this point
Copy the full SHA 9a3d613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11c812d - Browse repository at this point
Copy the full SHA 11c812dView commit details
Commits on Mar 26, 2024
-
Final clean-up, mostly linting; added a MORTARException class but end…
…ed up not using it yet;
Configuration menu - View commit details
-
Copy full SHA for 2efc444 - Browse repository at this point
Copy the full SHA 2efc444View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e8f5e3 - Browse repository at this point
Copy the full SHA 2e8f5e3View commit details
Commits on Mar 27, 2024
-
Final clean-up, mostly linting; fixed possible eternal loop in Prefer…
…enceContainer.delete(String); switched FileUtil.deleteFile() to nio files; changed fail behaviour of time stamp methods;
Configuration menu - View commit details
-
Copy full SHA for ef799ef - Browse repository at this point
Copy the full SHA ef799efView commit details -
Reduced duplication by moving translation of preferences to propertie…
…s and check of properties for preference restrictions to PreferenceUtil for SettingsContainer, FragmentationService, and ViewToolsManager;
Configuration menu - View commit details
-
Copy full SHA for 09047af - Browse repository at this point
Copy the full SHA 09047afView commit details
Commits on Mar 28, 2024
-
Added separate display name to fragmenters but not used yet; added no…
…te about JavaFx info message in log file when reducing the rows per page setting;
Configuration menu - View commit details
-
Copy full SHA for 7f42944 - Browse repository at this point
Copy the full SHA 7f42944View commit details -
Changed integer filter of settings view integer text fields to positi…
…ve integer filter including zero;
Configuration menu - View commit details
-
Copy full SHA for 26a7a3c - Browse repository at this point
Copy the full SHA 26a7a3cView commit details -
Changed double filter of settings view double text fields to positive…
… double filter including zero;
Configuration menu - View commit details
-
Copy full SHA for 481184a - Browse repository at this point
Copy the full SHA 481184aView commit details
Commits on Apr 2, 2024
-
Separated usage of algorithm name for internal use and algorithm disp…
…lay name for use in GUI; internal name is now mostly used for persistence;
Configuration menu - View commit details
-
Copy full SHA for 095a146 - Browse repository at this point
Copy the full SHA 095a146View commit details