Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some SonarCloud issues from the complete code analysis #49

Merged
merged 53 commits into from
Apr 2, 2024

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    cd537d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f3ea7 View commit details
    Browse the repository at this point in the history
  3. Same as before;

    JonasSchaub committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    59c1836 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df0fda7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. introduced a configuration properties file and changed a few things a…

    …ccording to SonarCloud suggestions; unfortunately, I broke the JAR execution with this because the resource files are not found anymore when executed from JAR, so WIP;
    JonasSchaub committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    bea1219 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Fixed import of resource files via configurations class, also works f…

    …rom JAR again now; added IConfiguration interface; added configurations as param in constructor of MainViewController and AboutViewController;
    JonasSchaub committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ef17d27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8910e4e View commit details
    Browse the repository at this point in the history
  3. Removed unused imports;

    JonasSchaub committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    73111a1 View commit details
    Browse the repository at this point in the history
  4. No more exceptions when a configurations instance is passed as param …

    …and not de novo constructed;
    JonasSchaub committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d3d0f7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    202c390 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    71d9a78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ba77f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6203b4c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'production' into sonar-issues-fix

    * production:
      Fix javadoc
      Add try-catch-block to sorting method
      Refine javadoc
      Add javadoc
      Fix Spotless requirements
      Optimize imports
      Change SortType to boolean
      Add enums to TableViews
      Add javadoc
      Add enum for data model properties
      Fix javadoc
      Change sort type to enum of TableColumn
    
    # Conflicts:
    #	src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
    JonasSchaub committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5843c12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51a1379 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26d9b3d View commit details
    Browse the repository at this point in the history
  4. Encapsulated the custom pagination with suitable page count creation …

    …into a separate method;
    JonasSchaub committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    62548b5 View commit details
    Browse the repository at this point in the history
  5. Separated overview view setting for first structure highlight and jum…

    …ping to molecule in molecules tab enabled;
    JonasSchaub committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2c29323 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e5638b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. More SonarCloud issues fixes, i.a. throwing specific exceptions in Vi…

    …ewToolsManager, making fields in MainMenuBar and FragmentsdataTableView final, adjusting some regex patterns, some manual linting, more documentation on how reflection is used to fill the data tables;
    JonasSchaub committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    39ecbc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    a2dc5fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c911c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f3702a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4590260 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    dd2f0a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89094bc View commit details
    Browse the repository at this point in the history
  3. Linting and fixing some sonar issues in FragmentationService mostly; …

    …introducing <?> operator to define undefined generic type of properties;
    JonasSchaub committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    52f0d09 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Fixing sonar complaints and linting in FragmentationTask and all frag…

    …mentation algorithm classes;
    JonasSchaub committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5ca25e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04961c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Overhaul of exporter, mostly exception treatment (more is passed on t…

    …o export thread now, so that it fails properly) and csv export methods return list of faulty molecules now as well;
    JonasSchaub committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6eaba95 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Fixed bug in items tab PDF export, number of fragments in header was …

    …not correct but same as number of molecules;
    JonasSchaub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bdc12be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3224b7c View commit details
    Browse the repository at this point in the history
  3. Fix spotless complaint;

    JonasSchaub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a45bb63 View commit details
    Browse the repository at this point in the history
  4. Changed CSV export separator char from being set directly to an enum …

    …constant defining the character;
    JonasSchaub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c0fc480 View commit details
    Browse the repository at this point in the history
  5. Overhaul of importer;

    JonasSchaub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b944857 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9b61c2d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9daa33f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7ae13f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    493d861 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c18817e View commit details
    Browse the repository at this point in the history
  3. Started working on a new custom property to wrap the language-specifi…

    …c display name of an enum constant; prepared the property-using classes like fragmenters, settings container, and view tools for its usage, i.e. no enum.valueof() calls anymore;
    JonasSchaub committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4af7a03 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Added SimpleIDisplayEnumConstantProperty as new JavaFX property that …

    …wraps an enum constant with associated display name and tooltip to be used in the GUI; started replacing SimpleEnumConstantNameProperty settings with the new property;
    JonasSchaub committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d8f1847 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Replaced all SimpleEnumConstantNameProperty settings with SimpleIDisp…

    …layEnumConstantProperty settings; implemented a central method for tooltip generation with max width and text wrap;
    JonasSchaub committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e494708 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Updated spotless; moved openFilePathInExplorer() to FileUtil; overhau…

    …l of preferences; general linting;
    JonasSchaub committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9a3d613 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11c812d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Final clean-up, mostly linting; added a MORTARException class but end…

    …ed up not using it yet;
    JonasSchaub committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2efc444 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e8f5e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Final clean-up, mostly linting; fixed possible eternal loop in Prefer…

    …enceContainer.delete(String); switched FileUtil.deleteFile() to nio files; changed fail behaviour of time stamp methods;
    JonasSchaub committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ef799ef View commit details
    Browse the repository at this point in the history
  2. Reduced duplication by moving translation of preferences to propertie…

    …s and check of properties for preference restrictions to PreferenceUtil for SettingsContainer, FragmentationService, and ViewToolsManager;
    JonasSchaub committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    09047af View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Added separate display name to fragmenters but not used yet; added no…

    …te about JavaFx info message in log file when reducing the rows per page setting;
    JonasSchaub committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7f42944 View commit details
    Browse the repository at this point in the history
  2. Changed integer filter of settings view integer text fields to positi…

    …ve integer filter including zero;
    JonasSchaub committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    26a7a3c View commit details
    Browse the repository at this point in the history
  3. Changed double filter of settings view double text fields to positive…

    … double filter including zero;
    JonasSchaub committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    481184a View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Separated usage of algorithm name for internal use and algorithm disp…

    …lay name for use in GUI; internal name is now mostly used for persistence;
    JonasSchaub committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    095a146 View commit details
    Browse the repository at this point in the history