Fixed some SonarCloud issues from the complete code analysis #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccording to SonarCloud suggestions; unfortunately, I broke the JAR execution with this because the resource files are not found anymore when executed from JAR, so WIP;
…rom JAR again now; added IConfiguration interface; added configurations as param in constructor of MainViewController and AboutViewController;
…tion properties file;
…and not de novo constructed;
Closed
* production: Fix javadoc Add try-catch-block to sorting method Refine javadoc Add javadoc Fix Spotless requirements Optimize imports Change SortType to boolean Add enums to TableViews Add javadoc Add enum for data model properties Fix javadoc Change sort type to enum of TableColumn # Conflicts: # src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
…into a separate method;
…ping to molecule in molecules tab enabled;
…ewToolsManager, making fields in MainMenuBar and FragmentsdataTableView final, adjusting some regex patterns, some manual linting, more documentation on how reflection is used to fill the data tables;
| @@ -252,7 +251,7 @@ public static void guiBindControlSizeToParentPane(Pane aParentPane, Control aChi | |||
| * @return GUI input pattern for integer values | |||
| */ | |||
| public static Pattern getIntegerPattern(){ | |||
| return Pattern.compile("-?(([1-9][0-9]*)|0)?"); | |||
| return Pattern.compile("-?(([1-9]\\d*)|0)?"); | |||
There was a problem hiding this comment.
Be careful with this, [0-9] is not always equivalent to \d
There was a problem hiding this comment.
Thank you for noticing! I think I'm going to reverse this anyway since [0-9] is more straightforward for people not dealing with regex every day (i.e. me and potential students)...
…in the background);
…introducing <?> operator to define undefined generic type of properties;
…constant defining the character;
…c display name of an enum constant; prepared the property-using classes like fragmenters, settings container, and view tools for its usage, i.e. no enum.valueof() calls anymore;
…wraps an enum constant with associated display name and tooltip to be used in the GUI; started replacing SimpleEnumConstantNameProperty settings with the new property;
…layEnumConstantProperty settings; implemented a central method for tooltip generation with max width and text wrap;
…l of preferences; general linting;
…ed up not using it yet;
…enceContainer.delete(String); switched FileUtil.deleteFile() to nio files; changed fail behaviour of time stamp methods;
…s and check of properties for preference restrictions to PreferenceUtil for SettingsContainer, FragmentationService, and ViewToolsManager;
This was referenced Mar 27, 2024
|
To do: Write changelog and then merge. |
…te about JavaFx info message in log file when reducing the rows per page setting;
|
To do: separate names and display names of fragmenters. |
…ve integer filter including zero;
… double filter including zero;
…lay name for use in GUI; internal name is now mostly used for persistence;
|
|
Complete changelog of this branch / pull request:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.