Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View size bug #305

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

jbloomAus
Copy link
Contributor

Description

ViewSize wrapper was not working. Once you change the class to ObservationWrapper it works.
Also noticed a black-unformatted file (test_envs) so fixed that.

Fixes issue # ??? Not opened or I couldn't find it. I need this to work.

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots.

Unecessary

Checklist:

  • [ x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes

No reason to add documentation. Check ensures it works.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Looks good

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 0a6449d into Farama-Foundation:master Feb 14, 2023
@jbloomAus jbloomAus deleted the view-size-bug branch April 6, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants